base/process_util_linux.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process_util_linux.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process_util_linux.cc

diff --git a/base/process_util_linux.cc b/base/process_util_linux.cc

index 2af922712125d5dbd5e03c1905c9ef156f075859..e06d99cf599ea3f232a578027cac8fdbdc0a76b9 100644

--- a/base/process_util_linux.cc

+++ b/base/process_util_linux.cc

@@ -161,7 +161,7 @@ std::string GetProcStatsFieldAsString(

ProcStatsFields field_num) {

if (field_num < VM_COMM || field_num > VM_STATE) {

NOTREACHED();

- return "";

+ return std::string();

}

if (proc_stats.size() > static_cast<size_t>(field_num))