Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1314273002: Manage UsbService lifetime in DeviceClient implementations. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manage UsbService lifetime in DeviceClient implementations. To make it easier to reason about when the UsbService is destroyed this patch makes its lifetime managed by the DeviceClient implementation that created it. This means that in Chrome the UsbService is (indirectly) owned by BrowserProcessImpl. BUG=None TBR=dgozman@chromium.org Committed: https://crrev.com/badbc5415c4cd4d4870b2ca2122b1b9988e341d7 Cr-Commit-Position: refs/heads/master@{#346264}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -66 lines) Patch
M chrome/browser/chrome_device_client.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 6 chunks +25 lines, -15 lines 0 comments Download
M device/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/core/device_client.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M device/device_tests.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M device/devices_app/devices_app.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M device/hid/hid_connection_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
A device/test/test_device_client.h View 1 chunk +31 lines, -0 lines 0 comments Download
A device/test/test_device_client.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M device/test/usb_test_gadget_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/usb_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/usb_device_handle_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M device/usb/usb_service.h View 2 chunks +4 lines, -3 lines 0 comments Download
M device/usb/usb_service.cc View 2 chunks +4 lines, -24 lines 0 comments Download
M device/usb/usb_service_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/usb/usb_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/usb_service_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 7 chunks +22 lines, -7 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_device_client.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Reilly Grant (use Gerrit)
Please take a look. I've finally drunk the globals are evil koolaid.
5 years, 3 months ago (2015-08-28 20:21:51 UTC) #7
Ken Rockot(use gerrit already)
and lgtm
5 years, 3 months ago (2015-08-28 22:54:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314273002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314273002/100001
5 years, 3 months ago (2015-08-28 22:56:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:100001)
5 years, 3 months ago (2015-08-28 23:08:18 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 23:08:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/badbc5415c4cd4d4870b2ca2122b1b9988e341d7
Cr-Commit-Position: refs/heads/master@{#346264}

Powered by Google App Engine
This is Rietveld 408576698