Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1312993008: Manage HidService lifetime in DeviceClient implementations. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_usb_service_get_instance
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manage HidService lifetime in DeviceClient implementations. To make it easier to reason about when the HidService is destroyed this patch makes its lifetime managed by the DeviceClient implementation that created it. This means that in Chrome the HidService is (indirectly) owned by BrowserProcessImpl. BUG=None Committed: https://crrev.com/33338fc038bed55f7f32c0805eee01e2b88f1c13 Cr-Commit-Position: refs/heads/master@{#346272}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -76 lines) Patch
M chrome/browser/chrome_device_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M device/hid/hid_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service.h View 2 chunks +4 lines, -7 lines 0 comments Download
M device/hid/hid_service.cc View 2 chunks +6 lines, -23 lines 0 comments Download
M device/hid/hid_service_linux.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/hid/hid_service_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M device/hid/hid_service_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/hid/hid_service_mac.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M device/hid/hid_service_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/hid/hid_service_win.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M device/test/test_device_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/test/test_device_client.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M extensions/browser/api/hid/hid_apitest.cc View 6 chunks +25 lines, -9 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_device_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Reilly Grant (use Gerrit)
Please take a look. I'm liking this pattern more and more.
5 years, 3 months ago (2015-08-28 22:34:59 UTC) #5
Ken Rockot(use gerrit already)
nice - lgtm
5 years, 3 months ago (2015-08-28 22:53:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312993008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312993008/60001
5 years, 3 months ago (2015-08-28 23:11:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 3 months ago (2015-08-28 23:41:16 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 23:42:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33338fc038bed55f7f32c0805eee01e2b88f1c13
Cr-Commit-Position: refs/heads/master@{#346272}

Powered by Google App Engine
This is Rietveld 408576698