Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: chrome/browser/chrome_device_client.cc

Issue 1314273002: Manage UsbService lifetime in DeviceClient implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_device_client.cc
diff --git a/chrome/browser/chrome_device_client.cc b/chrome/browser/chrome_device_client.cc
index 835a4c3a57782af555671849cdb89ca5fc3e9abd..0926a1fe9c57151533959b34a7bed99417618a87 100644
--- a/chrome/browser/chrome_device_client.cc
+++ b/chrome/browser/chrome_device_client.cc
@@ -17,8 +17,11 @@ ChromeDeviceClient::~ChromeDeviceClient() {}
device::UsbService* ChromeDeviceClient::GetUsbService() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- return device::UsbService::GetInstance(
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
+ if (!usb_service_) {
+ usb_service_ = device::UsbService::Create(
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
+ }
+ return usb_service_.get();
}
device::HidService* ChromeDeviceClient::GetHidService() {
« no previous file with comments | « chrome/browser/chrome_device_client.h ('k') | chrome/browser/devtools/device/usb/android_usb_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698