Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 1313883002: Introduce firstRangeOf() as replacement of VisibleSelection::firstRange() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce firstRangeOf() as replacement of VisibleSelection::firstRange() This patch introduces |firstRangeOf()| function as replacement of |firstRange()| member function of |VisibleSelection| to prepare templatizing |VisibleSelection| to exclude DOM tree position specific function out from |VisibleSelection| for ease of templatizing. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201122

Patch Set 1 : 2015-08-25T17:47:14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -35 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SurroundingTextTest.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/InsertListCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/TextFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-25 09:24:22 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-25 09:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313883002/1
5 years, 4 months ago (2015-08-25 09:34:14 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:36:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201122

Powered by Google App Engine
This is Rietveld 408576698