Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: Source/core/editing/FrameSelection.cpp

Issue 1313883002: Introduce firstRangeOf() as replacement of VisibleSelection::firstRange() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-25T17:47:14 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1482 matching lines...) Expand 10 before | Expand all | Expand 10 after
1493 VisibleSelection newSelection(range.startPosition(), range.endPosition(), af finity, directional == Directional); 1493 VisibleSelection newSelection(range.startPosition(), range.endPosition(), af finity, directional == Directional);
1494 setSelection(newSelection, options); 1494 setSelection(newSelection, options);
1495 startObservingVisibleSelectionChange(); 1495 startObservingVisibleSelectionChange();
1496 return true; 1496 return true;
1497 } 1497 }
1498 1498
1499 PassRefPtrWillBeRawPtr<Range> FrameSelection::firstRange() const 1499 PassRefPtrWillBeRawPtr<Range> FrameSelection::firstRange() const
1500 { 1500 {
1501 if (m_logicalRange) 1501 if (m_logicalRange)
1502 return m_logicalRange->cloneRange(); 1502 return m_logicalRange->cloneRange();
1503 return m_selection.firstRange(); 1503 return firstRangeOf(m_selection);
1504 } 1504 }
1505 1505
1506 bool FrameSelection::isInPasswordField() const 1506 bool FrameSelection::isInPasswordField() const
1507 { 1507 {
1508 HTMLTextFormControlElement* textControl = enclosingTextFormControl(start()); 1508 HTMLTextFormControlElement* textControl = enclosingTextFormControl(start());
1509 return isHTMLInputElement(textControl) && toHTMLInputElement(textControl)->t ype() == InputTypeNames::password; 1509 return isHTMLInputElement(textControl) && toHTMLInputElement(textControl)->t ype() == InputTypeNames::password;
1510 } 1510 }
1511 1511
1512 void FrameSelection::notifyAccessibilityForSelectionChange() 1512 void FrameSelection::notifyAccessibilityForSelectionChange()
1513 { 1513 {
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
2058 2058
2059 void showTree(const blink::FrameSelection* sel) 2059 void showTree(const blink::FrameSelection* sel)
2060 { 2060 {
2061 if (sel) 2061 if (sel)
2062 sel->showTreeForThis(); 2062 sel->showTreeForThis();
2063 else 2063 else
2064 fprintf(stderr, "Cannot showTree for (nil) FrameSelection.\n"); 2064 fprintf(stderr, "Cannot showTree for (nil) FrameSelection.\n");
2065 } 2065 }
2066 2066
2067 #endif 2067 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698