Source/modules/accessibility/AXLayoutObject.cpp - Issue 1313883002: Introduce firstRangeOf() as replacement of VisibleSelection::firstRange()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1313883002: Introduce firstRangeOf() as replacement of VisibleSelection::firstRange() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-25T17:47:14 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp

index d83ea0a273641518dce732e6d3fa46df00d5161c..2d4976431777b4cb7ea0fd4af4c52b03afaaccf5 100644

--- a/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1850,7 +1850,7 @@ AXObject::AXRange AXLayoutObject::selection() const

return AXRange();

VisibleSelection selection = layoutObject()->frame()->selection().selection();

- RefPtrWillBeRawPtr<Range> selectionRange = selection.firstRange();

+ RefPtrWillBeRawPtr<Range> selectionRange = firstRangeOf(selection);

if (!selectionRange)

return AXRange();

@@ -1911,7 +1911,7 @@ AXObject::AXRange AXLayoutObject::selectionUnderObject() const

return AXRange();

VisibleSelection selection = layoutObject()->frame()->selection().selection();

- RefPtrWillBeRawPtr<Range> selectionRange = selection.firstRange();

+ RefPtrWillBeRawPtr<Range> selectionRange = firstRangeOf(selection);

ContainerNode* parentNode = node()->parentNode();

int nodeIndex = node()->nodeIndex();

if (!selectionRange

« no previous file with comments | « Source/core/editing/commands/InsertListCommand.cpp ('k') | Source/web/TextFinder.cpp » ('j') | no next file with comments »