Introduce firstRangeOf() as replacement of VisibleSelection::firstRange()

Source/core/editing/commands/InsertListCommand.cpp

 /*
  * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 128 matching lines @@
 
     const HTMLQualifiedName& listTag = (m_type == OrderedList) ? olTag : ulTag;
     if (endingSelection().isRange()) {
         bool forceListCreation = false;
         VisibleSelection selection = selectionForParagraphIteration(endingSelection());
         ASSERT(selection.isRange());
         VisiblePosition startOfSelection = selection.visibleStart();
         VisiblePosition endOfSelection = selection.visibleEnd();
         VisiblePosition startOfLastParagraph = startOfParagraph(endOfSelection, CanSkipOverEditingBoundary);
 
-        RefPtrWillBeRawPtr<Range> currentSelection = endingSelection().firstRange();
+        RefPtrWillBeRawPtr<Range> currentSelection = firstRangeOf(endingSelection());
         RefPtrWillBeRawPtr<ContainerNode> scopeForStartOfSelection = nullptr;
         RefPtrWillBeRawPtr<ContainerNode> scopeForEndOfSelection = nullptr;
         // FIXME: This is an inefficient way to keep selection alive because
         // indexForVisiblePosition walks from the beginning of the document to the
         // endOfSelection everytime this code is executed. But not using index is hard
         // because there are so many ways we can los eselection inside doApplyForSingleParagraph.
         int indexForStartOfSelection = indexForVisiblePosition(startOfSelection, scopeForStartOfSelection);
         int indexForEndOfSelection = indexForVisiblePosition(endOfSelection, scopeForEndOfSelection);
 
         if (startOfParagraph(startOfSelection, CanSkipOverEditingBoundary).deepEquivalent() != startOfLastParagraph.deepEquivalent()) {
@@ skipping 37 matching lines @@
         }
         if (startOfSelection.isNull() || startOfSelection.isOrphan()) {
             startOfSelection = visiblePositionForIndex(indexForStartOfSelection, scopeForStartOfSelection.get());
             if (startOfSelection.isNull())
                 return;
         }
         setEndingSelection(VisibleSelection(startOfSelection, endOfSelection, endingSelection().isDirectional()));
         return;
     }
 
-    ASSERT(endingSelection().firstRange());
-    doApplyForSingleParagraph(false, listTag, *endingSelection().firstRange());
+    ASSERT(firstRangeOf(endingSelection()));
+    doApplyForSingleParagraph(false, listTag, *firstRangeOf(endingSelection()));
 }
 
 bool InsertListCommand::doApplyForSingleParagraph(bool forceCreateList, const HTMLQualifiedName& listTag, Range& currentSelection)
 {
     // FIXME: This will produce unexpected results for a selection that starts just before a
     // table and ends inside the first cell, selectionForParagraphIteration should probably
     // be renamed and deployed inside setEndingSelection().
     Node* selectionNode = endingSelection().start().anchorNode();
     Node* listChildNode = enclosingListChild(selectionNode);
     bool switchListType = false;
@@ skipping 208 matching lines @@
     return listElement;
 }
 
 DEFINE_TRACE(InsertListCommand)
 {
     visitor->trace(m_listElement);
     CompositeEditCommand::trace(visitor);
 }
 
 }