Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1313503004: Delete redundant MobileRendererCrashed count. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 67f0e5b6558ee4a6b681fb92be9ff94a7f705b05..89dc6f0a212255cdf036ac9a75efa165b144262c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -596,9 +596,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
} else {
rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_SHOWN_IN_FOREGROUND_APP;
showSadTab();
- // TODO(jaekyun): This isn't needed anymore because a histogram
- // "Tab.RendererCrashStatus" is recorded.
- UmaSessionStats.logRendererCrash(mWindowAndroid.getActivity().get());
+ // This is necessary to correlate histogram data with stability counts.
+ UmaSessionStats.logRendererCrash();
}
RecordHistogram.recordEnumeratedHistogram(
"Tab.RendererCrashStatus", rendererCrashStatus, TAB_RENDERER_CRASH_STATUS_MAX);

Powered by Google App Engine
This is Rietveld 408576698