Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3871)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

Issue 1313503004: Delete redundant MobileRendererCrashed count. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
index 62e9efae011554dff28fe04c6d16f15e74b80096..941e38c4c249dd51a3ff852ff37a532f6d256da1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
@@ -4,14 +4,11 @@
package org.chromium.chrome.browser.metrics;
-import android.app.Activity;
import android.content.ComponentCallbacks;
import android.content.Context;
import android.content.res.Configuration;
import android.text.TextUtils;
-import org.chromium.base.ActivityState;
-import org.chromium.base.ApplicationStatus;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.privacy.CrashReportingPermissionManager;
import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;
@@ -146,12 +143,8 @@ public class UmaSessionStats implements NetworkChangeNotifier.ConnectionTypeObse
NetworkChangeNotifier.removeConnectionTypeObserver(this);
}
- public static void logRendererCrash(Activity activity) {
- int activityState = ApplicationStatus.getStateForActivity(activity);
- nativeLogRendererCrash(
- activityState == ActivityState.PAUSED
- || activityState == ActivityState.STOPPED
- || activityState == ActivityState.DESTROYED);
+ public static void logRendererCrash() {
+ nativeLogRendererCrash();
}
/**
@@ -209,7 +202,7 @@ public class UmaSessionStats implements NetworkChangeNotifier.ConnectionTypeObse
private native void nativeUpdateMetricsServiceState(boolean mayRecord, boolean mayUpload);
private native void nativeUmaResumeSession(long nativeUmaSessionStats);
private native void nativeUmaEndSession(long nativeUmaSessionStats);
- private static native void nativeLogRendererCrash(boolean isPaused);
+ private static native void nativeLogRendererCrash();
private static native void nativeRegisterExternalExperiment(int studyId,
int experimentId);
private static native void nativeRegisterSyntheticFieldTrial(
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698