Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/android/metrics/uma_session_stats.cc

Issue 1313503004: Delete redundant MobileRendererCrashed count. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/metrics/uma_session_stats.cc
diff --git a/chrome/browser/android/metrics/uma_session_stats.cc b/chrome/browser/android/metrics/uma_session_stats.cc
index 8d212479ca6a907e9065099f372dd5524d1cfcb7..0021a0cf585b4843e18ee2014c6d30a856b000fe 100644
--- a/chrome/browser/android/metrics/uma_session_stats.cc
+++ b/chrome/browser/android/metrics/uma_session_stats.cc
@@ -114,22 +114,13 @@ static void UpdateMetricsServiceState(JNIEnv* env,
}
// Renderer process crashed in the foreground.
-static void LogRendererCrash(JNIEnv* env,
- const JavaParamRef<jclass>& clazz,
- jboolean is_paused) {
+static void LogRendererCrash(JNIEnv*, const JavaParamRef<jclass>&) {
DCHECK(g_browser_process);
-
- if (!is_paused) {
- // Increment the renderer crash count in stability metrics.
- PrefService* pref = g_browser_process->local_state();
- DCHECK(pref);
- int value = pref->GetInteger(prefs::kStabilityRendererCrashCount);
- pref->SetInteger(prefs::kStabilityRendererCrashCount, value + 1);
- }
-
- // Note: When we are paused, any UI metric we increment may not make it to
- // the disk before we are killed. Treat the count below as a lower bound.
- content::RecordAction(base::UserMetricsAction("MobileRendererCrashed"));
+ // Increment the renderer crash count in stability metrics.
+ PrefService* pref = g_browser_process->local_state();
+ DCHECK(pref);
+ int value = pref->GetInteger(prefs::kStabilityRendererCrashCount);
+ pref->SetInteger(prefs::kStabilityRendererCrashCount, value + 1);
}
static void RegisterExternalExperiment(JNIEnv* env,
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698