Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1313503004: Delete redundant MobileRendererCrashed count. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.tab; 5 package org.chromium.chrome.browser.tab;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.content.res.Resources; 10 import android.content.res.Resources;
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 mNeedsReload = true; 589 mNeedsReload = true;
590 if (ApplicationStatus.getStateForApplication() 590 if (ApplicationStatus.getStateForApplication()
591 == ApplicationState.HAS_RUNNING_ACTIVITIES) { 591 == ApplicationState.HAS_RUNNING_ACTIVITIES) {
592 rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_FO REGROUND_APP; 592 rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_FO REGROUND_APP;
593 } else { 593 } else {
594 rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_BA CKGROUND_APP; 594 rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_BA CKGROUND_APP;
595 } 595 }
596 } else { 596 } else {
597 rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_SHOWN_IN_FOREGRO UND_APP; 597 rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_SHOWN_IN_FOREGRO UND_APP;
598 showSadTab(); 598 showSadTab();
599 // TODO(jaekyun): This isn't needed anymore because a histogram 599 // This is necessary to correlate histogram data with stability counts.
600 // "Tab.RendererCrashStatus" is recorded. 600 UmaSessionStats.logRendererCrash();
601 UmaSessionStats.logRendererCrash(mWindowAndroid.getActivity().ge t());
602 } 601 }
603 RecordHistogram.recordEnumeratedHistogram( 602 RecordHistogram.recordEnumeratedHistogram(
604 "Tab.RendererCrashStatus", rendererCrashStatus, TAB_RENDERER _CRASH_STATUS_MAX); 603 "Tab.RendererCrashStatus", rendererCrashStatus, TAB_RENDERER _CRASH_STATUS_MAX);
605 604
606 mIsLoading = false; 605 mIsLoading = false;
607 mIsBeingRestored = false; 606 mIsBeingRestored = false;
608 handleTabCrash(); 607 handleTabCrash();
609 608
610 boolean sadTabShown = isShowingSadTab(); 609 boolean sadTabShown = isShowingSadTab();
611 RewindableIterator<TabObserver> observers = getTabObservers(); 610 RewindableIterator<TabObserver> observers = getTabObservers();
(...skipping 2285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2897 private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid , 2896 private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid ,
2898 ContentViewCore content, boolean visible); 2897 ContentViewCore content, boolean visible);
2899 private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid , 2898 private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid ,
2900 ContentViewCore content); 2899 ContentViewCore content);
2901 private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url); 2900 private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
2902 private native void nativeOnRendererUnresponsive(long nativeTabAndroid); 2901 private native void nativeOnRendererUnresponsive(long nativeTabAndroid);
2903 private native void nativeOnRendererResponsive(long nativeTabAndroid); 2902 private native void nativeOnRendererResponsive(long nativeTabAndroid);
2904 2903
2905 private static native void nativeRecordStartupToCommitUma(); 2904 private static native void nativeRecordStartupToCommitUma();
2906 } 2905 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698