Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed)

Created:
5 years, 4 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@resize
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools[LayoutEditor]: Rework layout-editor workflow BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201605

Patch Set 1 : #

Patch Set 2 : #

Total comments: 16

Patch Set 3 : Move everything to backend #

Patch Set 4 : #

Total comments: 13

Patch Set 5 : Address comments\ #

Patch Set 6 : Rebase on dgozman changes #

Total comments: 20

Patch Set 7 : Rebase on the refactored DomAgent #

Patch Set 8 : Small improvements #

Total comments: 12

Patch Set 9 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -126 lines) Patch
M Source/core/inspector/InspectorDOMAgent.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 3 4 5 6 7 4 chunks +2 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorHighlight.cpp View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.cpp View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 2 3 4 5 6 7 8 4 chunks +38 lines, -4 lines 0 comments Download
M Source/core/inspector/LayoutEditor.h View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -5 lines 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 3 4 5 6 7 8 5 chunks +29 lines, -3 lines 0 comments Download
M Source/devtools/front_end/components/InspectElementModeController.js View 1 2 3 4 5 6 2 chunks +21 lines, -7 lines 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 4 5 6 5 chunks +12 lines, -78 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M Source/web/InspectorOverlayImpl.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -0 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 4 5 6 7 8 11 chunks +49 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 1322053002 Patch 80001

Dependent Patchsets:

Issue 1310533007 Patch 80001

Messages

Total messages: 21 (5 generated)
sergeyv
5 years, 4 months ago (2015-08-24 22:33:37 UTC) #3
pfeldman
https://codereview.chromium.org/1311783003/diff/40001/Source/core/inspector/InspectorDOMAgent.h File Source/core/inspector/InspectorDOMAgent.h (right): https://codereview.chromium.org/1311783003/diff/40001/Source/core/inspector/InspectorDOMAgent.h#newcode267 Source/core/inspector/InspectorDOMAgent.h:267: bool m_searchingInLayoutEditorPaused; m_layoutEditorEnabled https://codereview.chromium.org/1311783003/diff/40001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): https://codereview.chromium.org/1311783003/diff/40001/Source/core/inspector/InspectorOverlayPage.html#newcode1059 Source/core/inspector/InspectorOverlayPage.html:1059: ...
5 years, 4 months ago (2015-08-24 23:18:14 UTC) #4
sergeyv
https://codereview.chromium.org/1311783003/diff/40001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): https://codereview.chromium.org/1311783003/diff/40001/Source/core/inspector/InspectorOverlayPage.html#newcode1059 Source/core/inspector/InspectorOverlayPage.html:1059: if (event.keyIdentifier === "U+001B") { On 2015/08/24 23:18:13, pfeldman ...
5 years, 4 months ago (2015-08-25 17:58:03 UTC) #5
pfeldman
https://codereview.chromium.org/1311783003/diff/80001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/1311783003/diff/80001/Source/core/inspector/InspectorDOMAgent.cpp#newcode1157 Source/core/inspector/InspectorDOMAgent.cpp:1157: if (m_searchingForNode == NotSearching || (m_searchingForNode == SearchingInLayoutEditor && ...
5 years, 4 months ago (2015-08-25 21:25:29 UTC) #6
sergeyv
https://codereview.chromium.org/1311783003/diff/80001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/1311783003/diff/80001/Source/core/inspector/InspectorDOMAgent.cpp#newcode1157 Source/core/inspector/InspectorDOMAgent.cpp:1157: if (m_searchingForNode == NotSearching || (m_searchingForNode == SearchingInLayoutEditor && ...
5 years, 4 months ago (2015-08-26 02:25:49 UTC) #7
pfeldman
https://codereview.chromium.org/1311783003/diff/80001/Source/devtools/front_end/sdk/DOMModel.js File Source/devtools/front_end/sdk/DOMModel.js (right): https://codereview.chromium.org/1311783003/diff/80001/Source/devtools/front_end/sdk/DOMModel.js#newcode1762 Source/devtools/front_end/sdk/DOMModel.js:1762: * @param {?string} mode On 2015/08/26 02:25:49, sergeyv wrote: ...
5 years, 3 months ago (2015-08-26 21:04:48 UTC) #8
pfeldman
Mind rebaselining on top of dgozman's changes?
5 years, 3 months ago (2015-08-27 19:05:24 UTC) #9
sergeyv
5 years, 3 months ago (2015-08-28 23:17:27 UTC) #11
sergeyv
5 years, 3 months ago (2015-08-28 23:17:28 UTC) #12
dgozman
1. Esc during drag. 2. setInspectModeEnabled should be reworked. 3. Let's first move overlay? https://codereview.chromium.org/1311783003/diff/120001/Source/core/inspector/InspectorDOMAgent.cpp ...
5 years, 3 months ago (2015-08-28 23:44:11 UTC) #13
sergeyv
https://codereview.chromium.org/1311783003/diff/120001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (left): https://codereview.chromium.org/1311783003/diff/120001/Source/core/inspector/InspectorDOMAgent.cpp#oldcode1142 Source/core/inspector/InspectorDOMAgent.cpp:1142: if (m_searchingForNode == NotSearching || event.type() != PlatformEvent::GestureTap) On ...
5 years, 3 months ago (2015-09-02 00:40:58 UTC) #14
dgozman
lgtm with comments https://codereview.chromium.org/1311783003/diff/160001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1311783003/diff/160001/Source/core/inspector/LayoutEditor.cpp#newcode170 Source/core/inspector/LayoutEditor.cpp:170: m_isDirty = false; ASSERT(!m_isDirty) https://codereview.chromium.org/1311783003/diff/160001/Source/core/inspector/LayoutEditor.cpp#newcode275 Source/core/inspector/LayoutEditor.cpp:275: ...
5 years, 3 months ago (2015-09-02 01:17:22 UTC) #15
sergeyv
https://codereview.chromium.org/1311783003/diff/160001/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1311783003/diff/160001/Source/core/inspector/LayoutEditor.cpp#newcode170 Source/core/inspector/LayoutEditor.cpp:170: m_isDirty = false; On 2015/09/02 01:17:22, dgozman wrote: > ...
5 years, 3 months ago (2015-09-02 01:49:16 UTC) #16
pfeldman
lgtm
5 years, 3 months ago (2015-09-02 01:50:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311783003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311783003/180001
5 years, 3 months ago (2015-09-02 01:52:16 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 03:06:11 UTC) #21
Message was sent while issue was closed. 
Committed patchset #9 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201605

Powered by Google App Engine
This is Rietveld 408576698