Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322053002: Devtools: Move inspectMode logic from InspectorDomAgent to InspectorOverlayImpl (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, mlamouri+watch-blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, dcheng, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Move inspectMode logic from InspectorDomAgent to InspectorOverlayImpl BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201575

Patch Set 1 #

Total comments: 30

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Fix assert #

Patch Set 4 : Rearrange isEmpty #

Patch Set 5 : Fix win compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -218 lines) Patch
M Source/core/inspector/InspectorDOMAgent.h View 1 2 3 4 7 chunks +6 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 9 chunks +5 lines, -121 lines 0 comments Download
M Source/web/InspectorOverlayImpl.h View 1 2 3 4 5 chunks +13 lines, -5 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 15 chunks +160 lines, -16 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +1 line, -51 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1311783003 Patch 140001
Issue 1311783003 Patch 160001
Issue 1311783003 Patch 180001

Messages

Total messages: 20 (8 generated)
sergeyv
5 years, 3 months ago (2015-08-31 23:28:04 UTC) #2
dgozman
lgtm with comments https://codereview.chromium.org/1322053002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/1322053002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp#newcode444 Source/core/inspector/InspectorDOMAgent.cpp:444: ShadowRoot* InspectorDOMAgent::userAgentShadowRoot(Node* node) // static https://codereview.chromium.org/1322053002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp#newcode1118 ...
5 years, 3 months ago (2015-09-01 00:53:30 UTC) #3
sergeyv
https://codereview.chromium.org/1322053002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/1322053002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp#newcode444 Source/core/inspector/InspectorDOMAgent.cpp:444: ShadowRoot* InspectorDOMAgent::userAgentShadowRoot(Node* node) On 2015/09/01 00:53:29, dgozman wrote: > ...
5 years, 3 months ago (2015-09-01 03:41:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322053002/20001
5 years, 3 months ago (2015-09-01 03:41:51 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/107133)
5 years, 3 months ago (2015-09-01 03:51:25 UTC) #8
dgozman
https://codereview.chromium.org/1322053002/diff/20001/Source/web/InspectorOverlayImpl.cpp File Source/web/InspectorOverlayImpl.cpp (right): https://codereview.chromium.org/1322053002/diff/20001/Source/web/InspectorOverlayImpl.cpp#newcode345 Source/web/InspectorOverlayImpl.cpp:345: return !(hasAlwaysVisibleElements || m_inspectMode != InspectorDOMAgent::NotSearching || hasInvisibleInInspectModeElements); This ...
5 years, 3 months ago (2015-09-01 17:51:46 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322053002/40001
5 years, 3 months ago (2015-09-01 18:47:17 UTC) #11
sergeyv
https://codereview.chromium.org/1322053002/diff/20001/Source/web/InspectorOverlayImpl.cpp File Source/web/InspectorOverlayImpl.cpp (right): https://codereview.chromium.org/1322053002/diff/20001/Source/web/InspectorOverlayImpl.cpp#newcode345 Source/web/InspectorOverlayImpl.cpp:345: return !(hasAlwaysVisibleElements || m_inspectMode != InspectorDOMAgent::NotSearching || hasInvisibleInInspectModeElements); On ...
5 years, 3 months ago (2015-09-01 19:08:09 UTC) #12
pfeldman
lgtm
5 years, 3 months ago (2015-09-01 19:28:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322053002/60001
5 years, 3 months ago (2015-09-01 20:30:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322053002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322053002/80001
5 years, 3 months ago (2015-09-01 20:50:52 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 22:05:22 UTC) #20
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201575

Powered by Google App Engine
This is Rietveld 408576698