Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310533007: Devtools[LayoutEditor]: show resizer cursor over anchors (Closed)

Created:
5 years, 4 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools[LayoutEditor]: show resizer cursor over anchors BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201658

Patch Set 1 #

Total comments: 2

Patch Set 2 : OwnPtr #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Address comments #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -15 lines) Patch
M Source/core/inspector/InspectorOverlayPage.html View 1 2 3 4 4 chunks +40 lines, -13 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 4 5 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1311783003 Patch 180001

Dependent Patchsets:

Issue 1317913004 Patch 20001
Issue 1317913004 Patch 40001

Messages

Total messages: 10 (3 generated)
sergeyv
5 years, 4 months ago (2015-08-21 22:51:38 UTC) #2
pfeldman
https://codereview.chromium.org/1310533007/diff/1/Source/web/ChromeClientImpl.cpp File Source/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/1310533007/diff/1/Source/web/ChromeClientImpl.cpp#newcode664 Source/web/ChromeClientImpl.cpp:664: if (m_overrideCursor.type() == Cursor::Pointer) Why is this check here?
5 years, 4 months ago (2015-08-24 18:22:40 UTC) #3
sergeyv
https://codereview.chromium.org/1310533007/diff/1/Source/web/ChromeClientImpl.cpp File Source/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/1310533007/diff/1/Source/web/ChromeClientImpl.cpp#newcode664 Source/web/ChromeClientImpl.cpp:664: if (m_overrideCursor.type() == Cursor::Pointer) On 2015/08/24 18:22:40, pfeldman wrote: ...
5 years, 3 months ago (2015-08-26 01:57:41 UTC) #4
pfeldman
https://codereview.chromium.org/1310533007/diff/40001/Source/web/ChromeClientImpl.cpp File Source/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/1310533007/diff/40001/Source/web/ChromeClientImpl.cpp#newcode688 Source/web/ChromeClientImpl.cpp:688: if (m_overrideCursor) Why is this here? You should have ...
5 years, 3 months ago (2015-08-26 21:08:42 UTC) #5
pfeldman
lgtm
5 years, 3 months ago (2015-08-26 23:26:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533007/80001
5 years, 3 months ago (2015-09-02 16:01:05 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 18:19:07 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201658

Powered by Google App Engine
This is Rietveld 408576698