Source/devtools/front_end/components/InspectorView.js - Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/InspectorView.js

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resize

Patch Set: Address comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/components/InspectElementModeController.js ('k') | Source/devtools/front_end/elements/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/InspectorView.js

diff --git a/Source/devtools/front_end/components/InspectorView.js b/Source/devtools/front_end/components/InspectorView.js

index 734adb9e9d5e4f4d43042bde0bda8a5a04b6728a..9fbdefc3b3d956faa287fa783a7c0a3f4493a337 100644

--- a/Source/devtools/front_end/components/InspectorView.js

+++ b/Source/devtools/front_end/components/InspectorView.js

@@ -281,9 +281,10 @@ WebInspector.InspectorView.prototype = {

/**

* @param {!WebInspector.Panel} panel

+ * @param {boolean=} suppressBringToFront

* @return {!WebInspector.Panel}

- setCurrentPanel: function(panel)

+ setCurrentPanel: function(panel, suppressBringToFront)

{

delete this._panelForShowPromise;

@@ -291,7 +292,9 @@ WebInspector.InspectorView.prototype = {

console.error("Current panel is locked");

return this._currentPanel;

}

- InspectorFrontendHost.bringToFront();

+ if (!suppressBringToFront)

+ InspectorFrontendHost.bringToFront();

if (this._currentPanel === panel)

return panel;