Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1313773003: Convert blink_heap_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 4 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert blink_heap_unittests to run exclusively on Swarming 0 configs already ran on Swarming 43 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.webkit.json: WebKit Linux - chromium.webkit.json: WebKit Linux (dbg) - chromium.webkit.json: WebKit Linux 32 - chromium.webkit.json: WebKit Linux Leak - chromium.webkit.json: WebKit Linux Oilpan - chromium.webkit.json: WebKit Linux Oilpan (dbg) - chromium.webkit.json: WebKit Linux Oilpan Leak - chromium.webkit.json: WebKit Linux Trusty - chromium.webkit.json: WebKit Mac Oilpan - chromium.webkit.json: WebKit Mac Oilpan (dbg) - chromium.webkit.json: WebKit Mac10.10 - chromium.webkit.json: WebKit Mac10.6 - chromium.webkit.json: WebKit Mac10.6 (dbg) - chromium.webkit.json: WebKit Mac10.7 - chromium.webkit.json: WebKit Mac10.7 (dbg) - chromium.webkit.json: WebKit Mac10.8 - chromium.webkit.json: WebKit Mac10.9 - chromium.webkit.json: WebKit Mac10.9 (retina) - chromium.webkit.json: WebKit Win Oilpan - chromium.webkit.json: WebKit Win Oilpan (dbg) - chromium.webkit.json: WebKit Win x64 Builder - chromium.webkit.json: WebKit Win x64 Builder (dbg) - chromium.webkit.json: WebKit Win10 - chromium.webkit.json: WebKit Win7 - chromium.webkit.json: WebKit Win7 (dbg) - chromium.webkit.json: WebKit XP Ran: ./manage.py --convert blink_heap_unittests R=maruel@chromium.org,dpranke@chromium.org BUG=98637, 524758 Committed: https://crrev.com/71fb00c11f88916f34b8005528667b333d55962a Cr-Commit-Position: refs/heads/master@{#348729}

Patch Set 1 #

Patch Set 2 : add updated manage.py #

Patch Set 3 : merge changes and rerun manage.py #

Total comments: 1

Patch Set 4 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -1 line) Patch
M build/gn_migration.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 17 chunks +51 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 2 26 chunks +78 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (2 generated)
joelo
Depends on https://codereview.chromium.org/1316763004/ Note that I had to modify testing/buildbot/manage.py locally so that it would ...
5 years, 4 months ago (2015-08-26 00:34:41 UTC) #1
Dirk Pranke
On 2015/08/26 00:34:41, joelo wrote: > Depends on https://codereview.chromium.org/1316763004/ > > Note that I had ...
5 years, 3 months ago (2015-08-26 00:55:31 UTC) #2
joelo
On 2015/08/26 00:55:31, Dirk Pranke wrote: > On 2015/08/26 00:34:41, joelo wrote: > > Depends ...
5 years, 3 months ago (2015-08-26 01:20:22 UTC) #3
Dirk Pranke
lgtm, but please wait for maruel's review also.
5 years, 3 months ago (2015-08-26 01:27:33 UTC) #4
joelo
Looks like the swarming is now getting triggered correctly on the blink trybots. maruel@: ptal? ...
5 years, 3 months ago (2015-09-14 20:09:17 UTC) #5
M-A Ruel
On 2015/09/14 20:09:17, joelo wrote: > Looks like the swarming is now getting triggered correctly ...
5 years, 3 months ago (2015-09-14 20:13:07 UTC) #6
M-A Ruel
https://codereview.chromium.org/1313773003/diff/40001/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1313773003/diff/40001/build/gn_migration.gypi#newcode524 build/gn_migration.gypi:524: '../third_party/WebKit/Source/platform/blink_platform_tests.gyp:blink_heap_unittests_run', alignment
5 years, 3 months ago (2015-09-14 20:13:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313773003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313773003/60001
5 years, 3 months ago (2015-09-14 20:20:04 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-14 21:51:19 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/71fb00c11f88916f34b8005528667b333d55962a Cr-Commit-Position: refs/heads/master@{#348729}
5 years, 3 months ago (2015-09-14 21:51:52 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:39 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/71fb00c11f88916f34b8005528667b333d55962a
Cr-Commit-Position: refs/heads/master@{#348729}

Powered by Google App Engine
This is Rietveld 408576698