Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1310533002: Move {next,previous}PositionOf() to EditingUtilities.{cpp,h} from Position.{cpp,h} (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move {next,previous}PositionOf() to EditingUtilities.{cpp,h} from Position.{cpp,h} This patch moves |{next,previous}PositionOf()| to "EditingUtilities.{cpp,h}" from "Position.{cpp,h}" to simplify "Position.{cpp,h}" for improving code health since |{next,previous}PositionOf()| don't depend of implementation of |PositionAlgorithm| template class. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201033

Patch Set 1 : 2015-08-21T19:44:25 #

Patch Set 2 : 2015-08-22T03:58:24 Rebase #

Patch Set 3 : 2015-08-22T09:42:03 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -137 lines) Patch
M Source/core/editing/EditingUtilities.h View 3 chunks +18 lines, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 2 1 chunk +107 lines, -0 lines 0 comments Download
M Source/core/editing/Position.h View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 2 2 chunks +0 lines, -115 lines 0 comments Download
M Source/core/layout/PendingSelection.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
yosin_UTC9
PTAL Sorry, this patch contains changes in http://crrev.com/1305963003, which introduce {next,previous}PositionOf() in "Position.cpp". This patch ...
5 years, 4 months ago (2015-08-21 10:46:58 UTC) #2
yosin_UTC9
I'll commit this patch after http://crrev.com/1305963003
5 years, 4 months ago (2015-08-21 10:47:25 UTC) #3
keishi
LGTM
5 years, 4 months ago (2015-08-21 11:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533002/1
5 years, 4 months ago (2015-08-21 14:06:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102329)
5 years, 4 months ago (2015-08-21 14:08:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533002/1
5 years, 4 months ago (2015-08-21 18:33:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102496)
5 years, 4 months ago (2015-08-21 18:36:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533002/20001
5 years, 4 months ago (2015-08-21 18:59:32 UTC) #18
commit-bot: I haz the power
Failed to apply patch for Source/core/editing/PositionTest.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 4 months ago (2015-08-21 22:03:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533002/40001
5 years, 4 months ago (2015-08-22 00:42:50 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/23293)
5 years, 4 months ago (2015-08-22 01:29:51 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533002/40001
5 years, 4 months ago (2015-08-22 01:31:28 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/23307)
5 years, 4 months ago (2015-08-22 01:50:49 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533002/40001
5 years, 4 months ago (2015-08-22 01:53:07 UTC) #32
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 02:45:56 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201033

Powered by Google App Engine
This is Rietveld 408576698