Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: Source/core/editing/Position.h

Issue 1310533002: Move {next,previous}PositionOf() to EditingUtilities.{cpp,h} from Position.{cpp,h} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-22T09:42:03 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/EditingUtilities.cpp ('k') | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.h
diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h
index 9294f3d16c515dc858586d4093af3d2bb1e661c0..caa8e862bfa59c3173a3a7515b05cc9134e41fa1 100644
--- a/Source/core/editing/Position.h
+++ b/Source/core/editing/Position.h
@@ -45,12 +45,6 @@ class Text;
enum class TextAffinity;
class TreeScope;
-enum class PositionMoveType {
- CodePoint, // Move by a single code point.
- Character, // Move to the next Unicode character break.
- BackwardDeletion // Subject to platform conventions.
-};
-
enum class PositionAnchorType : unsigned {
OffsetInAnchor,
BeforeAnchor,
@@ -396,21 +390,6 @@ inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrateg
return toPositionInComposedTree(position);
}
-// TODO(yosin) We should move |previousPositionOf()| and |nextPositionOf()|
-// to "EditingUtilities.h" with |uncheckedPreviousOffset()| and
-// |uncheckedNextOffset()|.
-// Move up or down the DOM by one position.
-// Offsets are computed using layout text for nodes that have layoutObjects -
-// but note that even when using composed characters, the result may be inside
-// a single user-visible character if a ligature is formed.
-CORE_EXPORT Position previousPositionOf(const Position&, PositionMoveType);
-CORE_EXPORT Position nextPositionOf(const Position&, PositionMoveType);
-CORE_EXPORT PositionInComposedTree previousPositionOf(const PositionInComposedTree&, PositionMoveType);
-CORE_EXPORT PositionInComposedTree nextPositionOf(const PositionInComposedTree&, PositionMoveType);
-
-CORE_EXPORT int uncheckedPreviousOffset(const Node*, int current);
-CORE_EXPORT int uncheckedNextOffset(const Node*, int current);
-
} // namespace blink
#ifndef NDEBUG
« no previous file with comments | « Source/core/editing/EditingUtilities.cpp ('k') | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698