Issue 1309943004: Revert of switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1309943004: Revert of switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE (Closed)

Created:
5 years, 3 months ago by scroggo

Modified:
5 years, 3 months ago

Reviewers:
reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE (patchset #3 id:40001 of https://codereview.chromium.org/1311963007/ ) Reason for revert: Broke the Android canary: https://internal.skia.org/builders/crimson-cherry-474438/builds/124 Original issue's description: > switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/2d126b5c45e65a67a9945afa9294038a8eb3f2c8 TBR=reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ff390c9bdd852405d9dc0fd5e384b1f935d8df08

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -20 lines)			Patch
M	include/core/SkShader.h	View	2 chunks	+35 lines, -13 lines	0 comments	Download
M	src/core/SkBitmapProcShader.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkBitmapProcShader.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/core/SkLocalMatrixShader.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/core/SkShader.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

Created Revert of switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE

5 years, 3 months ago (2015-09-08 13:23:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309943004/1

5 years, 3 months ago (2015-09-08 13:24:03 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 13:24:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ff390c9bdd852405d9dc0fd5e384b1f935d8df08

Expand Messages | Collapse Messages