Move GrGLProgramDesc::Build to new cpp file.

Move GrGLProgramDesc::Build to new cpp file.
Committed: https://code.google.com/p/skia/source/detail?r=8414

[robertphillips, 2013-03-27 18:44:52]

lgtm + some nits & a question

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:44: 
So -> so

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:51: desc->fColorFilterXfermode = skipColor ?
spaces

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:122: bool hasCoverage = false;
its -> it's

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:178: }
do we not have a kLocalCoordsOverrideAttribIndexValue?

[robertphillips, 2013-03-27 18:45:21]

lgtm + some nits & a question

[bsalomon, 2013-03-27 19:50:31]

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:44: 
On 2013/03/27 18:44:52, robertphillips wrote:
> So -> so

Done.

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:51: desc->fColorFilterXfermode = skipColor ?
On 2013/03/27 18:44:52, robertphillips wrote:
> spaces

Done.

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:122: bool hasCoverage = false;
On 2013/03/27 18:44:52, robertphillips wrote:
> its -> it's

Done.

https://codereview.chromium.org/13097007/diff/4001/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.cpp:178: }
On 2013/03/27 18:44:52, robertphillips wrote:
> do we not have a kLocalCoordsOverrideAttribIndexValue?

No. The override values are there because we sometimes specify constant color or
coverage as attributes rather than as uniforms (i.e. glVertexAttrib4f). We never
do that for local coords. If they aren't present we omit the attribute and the
effect gets positions as local coords.

[bsalomon, 2013-03-27 19:50:34]

Committed patchset #2 manually as r8414 (presubmit successful).