Source/devtools/front_end/audits/AuditRules.js - Issue 1308663002: DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/audits/AuditRules.js

Issue 1308663002: DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/audits/AuditRules.js

diff --git a/Source/devtools/front_end/audits/AuditRules.js b/Source/devtools/front_end/audits/AuditRules.js

index d14dcc89d5154fa6becbb892410113aec7286ca4..ae6c56fc99e5c588d7e953e1535dcd4e35b081cc 100644

--- a/Source/devtools/front_end/audits/AuditRules.js

+++ b/Source/devtools/front_end/audits/AuditRules.js

@@ -901,8 +901,8 @@ WebInspector.AuditRules.ImageDimensionsRule.prototype = {

return;

if (styles.attributesStyle) {

- var widthFound = !!styles.attributesStyle.getLiveProperty("width");

- var heightFound = !!styles.attributesStyle.getLiveProperty("height");

+ var widthFound = !!styles.attributesStyle.getPropertyValue("width");

+ var heightFound = !!styles.attributesStyle.getPropertyValue("height");

}

var inlineStyle = styles.inlineStyle;