Source/devtools/front_end/elements/MetricsSidebarPane.js - Issue 1308663002: DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 1308663002: DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/elements/MetricsSidebarPane.js

diff --git a/Source/devtools/front_end/elements/MetricsSidebarPane.js b/Source/devtools/front_end/elements/MetricsSidebarPane.js

index 2262bead95d2cb63da2dff32fea459e321079d4e..66f0df9b4dc4f18b95e67b4cc6329c235f66044f 100644

--- a/Source/devtools/front_end/elements/MetricsSidebarPane.js

+++ b/Source/devtools/front_end/elements/MetricsSidebarPane.js

@@ -447,7 +447,7 @@ WebInspector.MetricsSidebarPane.prototype = {

var allProperties = this.inlineStyle.allProperties;

for (var i = 0; i < allProperties.length; ++i) {

var property = allProperties[i];

- if (property.name !== context.styleProperty || property.inactive)

+ if (property.name !== context.styleProperty || !property.activeInStyle())

continue;

this.previousPropertyDataCandidate = property;