Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1306793003: Oilpan: Move FrameLoaderClient class hierarchy into Oilpan heap. (Closed)

Created:
5 years, 4 months ago by Yuta Kitamura
Modified:
5 years, 4 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, krit, mlamouri+watch-blink_chromium.org, rwlbuis, Yoav Weiss, kouhei+svg_chromium.org, fs, dcheng, f(malita), gavinp+loader_chromium.org, gyuyoung2, Stephen Chennney, Nate Chapin, kinuko+watch, pdr+svgwatchlist_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Move FrameLoaderClient class hierarchy into Oilpan heap. This patch fixes the raw pointer instances below: * StubFrameLoaderClientWithParent::m_parent * FrameLoaderClientImpl::m_webFrame * RemoteFrameClientImpl::m_webFrame BUG=509911 R=haraken@chromium.org, oilpan-reviews@chromium.org, peria@chromium.org, sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -46 lines) Patch
M Source/core/frame/FrameClient.h View 3 chunks +4 lines, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 2 chunks +18 lines, -7 lines 0 comments Download
M Source/core/page/PrintContextTest.cpp View 5 chunks +29 lines, -10 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/DummyPageHolder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/DummyPageHolder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 2 chunks +9 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/RemoteFrameClientImpl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/web/RemoteFrameClientImpl.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Yuta Kitamura
5 years, 4 months ago (2015-08-24 09:10:53 UTC) #1
peria
lgtm
5 years, 4 months ago (2015-08-25 03:28:19 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-25 03:39:11 UTC) #3
Yuta Kitamura
peria: I'm now sending PS1 to CQ. If that does not work for you, feel ...
5 years, 4 months ago (2015-08-25 03:57:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306793003/1
5 years, 4 months ago (2015-08-25 03:57:23 UTC) #6
peria
On 2015/08/25 03:57:05, Yuta Kitamura wrote: > peria: I'm now sending PS1 to CQ. If ...
5 years, 4 months ago (2015-08-25 04:01:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201105
5 years, 4 months ago (2015-08-25 05:26:22 UTC) #8
sof
What about the raw FrameLoaderClientImpl* in FrameLoaderClientImplTest ?
5 years, 4 months ago (2015-08-25 05:33:09 UTC) #9
Yuta Kitamura
5 years, 4 months ago (2015-08-25 09:38:02 UTC) #10
Message was sent while issue was closed.
On 2015/08/25 05:33:09, sof wrote:
> What about the raw FrameLoaderClientImpl* in FrameLoaderClientImplTest ?

Ah, that one somehow slipped off my radar. Will follow up soon.

Powered by Google App Engine
This is Rietveld 408576698