Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 1306793003: Oilpan: Move FrameLoaderClient class hierarchy into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/DummyPageHolder.cpp ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FrameLoaderClientImpl.h
diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h
index b2a6b9d1892877d2620aab1067dff2ba23e4c520..c70029a0c0d169398355966845d6c493148068cf 100644
--- a/Source/web/FrameLoaderClientImpl.h
+++ b/Source/web/FrameLoaderClientImpl.h
@@ -45,10 +45,13 @@ class WebPluginLoadObserver;
class FrameLoaderClientImpl final : public FrameLoaderClient {
public:
- explicit FrameLoaderClientImpl(WebLocalFrameImpl* webFrame);
+ static PassOwnPtrWillBeRawPtr<FrameLoaderClientImpl> create(WebLocalFrameImpl*);
+
~FrameLoaderClientImpl() override;
- WebLocalFrameImpl* webFrame() const { return m_webFrame; }
+ DECLARE_VIRTUAL_TRACE();
+
+ WebLocalFrameImpl* webFrame() const { return m_webFrame.get(); }
// FrameLoaderClient ----------------------------------------------
@@ -180,14 +183,17 @@ public:
unsigned backForwardLength() override;
void suddenTerminationDisablerChanged(bool present, SuddenTerminationDisablerType) override;
+
private:
+ explicit FrameLoaderClientImpl(WebLocalFrameImpl*);
+
bool isFrameLoaderClientImpl() const override { return true; }
PassOwnPtr<WebPluginLoadObserver> pluginLoadObserver(DocumentLoader*);
// The WebFrame that owns this object and manages its lifetime. Therefore,
// the web frame object is guaranteed to exist.
- WebLocalFrameImpl* m_webFrame;
+ RawPtrWillBeMember<WebLocalFrameImpl> m_webFrame;
};
DEFINE_TYPE_CASTS(FrameLoaderClientImpl, FrameLoaderClient, client, client->isFrameLoaderClientImpl(), client.isFrameLoaderClientImpl());
« no previous file with comments | « Source/core/testing/DummyPageHolder.cpp ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698