Source/web/WebPagePopupImpl.cpp - Issue 1306793003: Oilpan: Move FrameLoaderClient class hierarchy into Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 1306793003: Oilpan: Move FrameLoaderClient class hierarchy into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPagePopupImpl.cpp

diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp

index 7bcca7ee36afbe95a0be35eeedeb40b57af5b54f..64595f19b564599a1b6eb06251764d9459dc3e07 100644

--- a/Source/web/WebPagePopupImpl.cpp

+++ b/Source/web/WebPagePopupImpl.cpp

@@ -244,8 +244,8 @@ bool WebPagePopupImpl::initializePage()

m_page->settings().setScrollAnimatorEnabled(m_webView->page()->settings().scrollAnimatorEnabled());

provideContextFeaturesTo(*m_page, adoptPtr(new PagePopupFeaturesClient()));

- static FrameLoaderClient* emptyFrameLoaderClient = new EmptyFrameLoaderClient();

- RefPtrWillBeRawPtr<LocalFrame> frame = LocalFrame::create(emptyFrameLoaderClient, &m_page->frameHost(), 0);

+ DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<FrameLoaderClient>, emptyFrameLoaderClient, (EmptyFrameLoaderClient::create()));

+ RefPtrWillBeRawPtr<LocalFrame> frame = LocalFrame::create(emptyFrameLoaderClient.get(), &m_page->frameHost(), 0);

frame->setPagePopupOwner(m_popupClient->ownerElement());

frame->setView(FrameView::create(frame.get()));

frame->init();

« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebRemoteFrameImpl.h » ('j') | no next file with comments »