Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 1306793003: Oilpan: Move FrameLoaderClient class hierarchy into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebRemoteFrameImpl.cpp
diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp
index b85fd9c5693d880b81e4e85914786487ecbfd702..cbd5e8d753335880654eb8c814187f019d9cb746 100644
--- a/Source/web/WebRemoteFrameImpl.cpp
+++ b/Source/web/WebRemoteFrameImpl.cpp
@@ -44,6 +44,7 @@ WebRemoteFrameImpl::~WebRemoteFrameImpl()
#if ENABLE(OILPAN)
DEFINE_TRACE(WebRemoteFrameImpl)
{
+ visitor->trace(m_frameClient);
visitor->trace(m_frame);
visitor->trace(m_ownersForChildren);
visitor->template registerWeakMembers<WebFrame, &WebFrame::clearWeakFrames>(this);
@@ -722,7 +723,7 @@ WebLocalFrame* WebRemoteFrameImpl::createLocalChild(WebTreeScopeType scope, cons
void WebRemoteFrameImpl::initializeCoreFrame(FrameHost* host, FrameOwner* owner, const AtomicString& name)
{
- setCoreFrame(RemoteFrame::create(&m_frameClient, host, owner));
+ setCoreFrame(RemoteFrame::create(m_frameClient.get(), host, owner));
frame()->createView();
m_frame->tree().setName(name, nullAtom);
}
@@ -803,7 +804,7 @@ void WebRemoteFrameImpl::didStopLoading()
WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, WebRemoteFrameClient* client)
: WebRemoteFrame(scope)
- , m_frameClient(this)
+ , m_frameClient(RemoteFrameClientImpl::create(this))
, m_client(client)
#if ENABLE(OILPAN)
, m_selfKeepAlive(this)
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698