Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1305933002: [Android] Add email alerts on unauthorized devices. (Closed)

Created:
2 years, 3 months ago by jbudorick
Modified:
2 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add email alerts on unauthorized devices. BUG=523059 Committed: https://crrev.com/44f3ca54fa3c9680f042589655ff44594425ba37 Cr-Commit-Position: refs/heads/master@{#344754}

Patch Set 1 #

Total comments: 7

Messages

Total messages: 30 (10 generated)
jbudorick
This is the hard way of signing up for an email list.
2 years, 3 months ago (2015-08-21 01:04:21 UTC) #2
jbudorick
2 years, 3 months ago (2015-08-21 01:14:37 UTC) #4
jbudorick
2 years, 3 months ago (2015-08-21 02:05:25 UTC) #6
jbudorick
+other Armand
2 years, 3 months ago (2015-08-21 02:11:48 UTC) #8
rnephew (Wrong account)
https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode177 build/android/buildbot/bb_device_status_check.py:177: 'jbudorick@chromium.org', I'm not sure I like your email hardcoded ...
2 years, 3 months ago (2015-08-21 02:25:12 UTC) #10
jbudorick
https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode177 build/android/buildbot/bb_device_status_check.py:177: 'jbudorick@chromium.org', On 2015/08/21 at 02:25:12, rnephew wrote: > I'm ...
2 years, 3 months ago (2015-08-21 02:27:38 UTC) #11
jbudorick
https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode177 build/android/buildbot/bb_device_status_check.py:177: 'jbudorick@chromium.org', On 2015/08/21 at 02:27:38, jbudorick wrote: > On ...
2 years, 3 months ago (2015-08-21 02:28:31 UTC) #12
rnephew (Wrong account)
On 2015/08/21 02:28:31, jbudorick wrote: > https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py > File build/android/buildbot/bb_device_status_check.py (right): > > https://codereview.chromium.org/1305933002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode177 > ...
2 years, 3 months ago (2015-08-21 02:29:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305933002/1
2 years, 3 months ago (2015-08-21 02:31:36 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
2 years, 3 months ago (2015-08-21 02:31:39 UTC) #17
rnephew (Reviews Here)
On 2015/08/21 02:31:39, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
2 years, 3 months ago (2015-08-21 02:35:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305933002/1
2 years, 3 months ago (2015-08-21 02:40:24 UTC) #20
mikecase (-- gone --)
Same comment as Randy. I don't like sending the alerts to your email since (1) ...
2 years, 3 months ago (2015-08-21 02:40:53 UTC) #21
jbudorick
devices aren't usually unauthorized. the M SDK roll + broken 'adb get-state' killed _a lot_ ...
2 years, 3 months ago (2015-08-21 02:45:24 UTC) #22
mikecase (-- gone --)
lgtm
2 years, 3 months ago (2015-08-21 02:48:03 UTC) #23
jbudorick
On 2015/08/21 at 02:45:24, jbudorick wrote: > devices aren't usually unauthorized. the M SDK roll ...
2 years, 3 months ago (2015-08-21 03:53:03 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/96565)
2 years, 3 months ago (2015-08-21 05:31:27 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305933002/1
2 years, 3 months ago (2015-08-21 12:57:32 UTC) #28
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 3 months ago (2015-08-21 13:36:24 UTC) #29
commit-bot: I haz the power
2 years, 3 months ago (2015-08-21 13:36:57 UTC) #30
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44f3ca54fa3c9680f042589655ff44594425ba37
Cr-Commit-Position: refs/heads/master@{#344754}

Powered by Google App Engine
This is Rietveld efc10ee0f