[Android] Add email alerts on unauthorized devices.

build/android/buildbot/bb_device_status_check.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A class to keep track of devices across builds and report state."""
 import json
 import logging
 import optparse
@@ skipping 127 matching lines @@
 
   try:
     last_missing_devices = device_list.GetPersistentDeviceList(
         last_missing_devices_path)
   except IOError:
     last_missing_devices = []
 
   missing_devs = list(set(last_devices) - device_serials)
   new_missing_devs = list(set(missing_devs) - set(last_missing_devices))
 
-  if new_missing_devs and os.environ.get('BUILDBOT_SLAVENAME'):
+  buildbot_slavename = os.environ.get('BUILDBOT_SLAVENAME')
+  buildbot_buildername = os.environ.get('BUILDBOT_BUILDERNAME')
+  buildbot_buildnumber = os.environ.get('BUILDBOT_BUILDNUMBER')
+
+  if new_missing_devs and buildbot_slavename:
     logging.info('new_missing_devs %s' % new_missing_devs)
     devices_missing_msg = '%d devices not detected.' % len(missing_devs)
     bb_annotations.PrintSummaryText(devices_missing_msg)
 
     from_address = 'chrome-bot@chromium.org'
     to_addresses = ['chrome-labs-tech-ticket@google.com',
                     'chrome-android-device-alert@google.com']
     cc_addresses = ['chrome-android-device-alert@google.com']
     subject = 'Devices offline on %s, %s, %s' % (
-      os.environ.get('BUILDBOT_SLAVENAME'),
-      os.environ.get('BUILDBOT_BUILDERNAME'),
-      os.environ.get('BUILDBOT_BUILDNUMBER'))
+        buildbot_slavename, buildbot_buildername, buildbot_buildnumber)
     msg = ('Please reboot the following devices:\n%s' %
            '\n'.join(map(str, new_missing_devs)))
     SendEmail(from_address, to_addresses, cc_addresses, subject, msg)
 
+  unauthorized_devices = adb_wrapper.AdbWrapper.Devices(
+      desired_state='unauthorized')
+  if unauthorized_devices:
+    logging.info('unauthorized devices:')
+    for ud in unauthorized_devices:
+      logging.info('  %s', ud)
+
+    if buildbot_slavename:
+      from_address = 'chrome-bot@chromium.org'
+      to_addresses = [
+          'jbudorick@chromium.org',

[rnephew (Wrong account), 2015/08/21 02:25:12]

I'm not sure I like your email hardcoded in here, but its your inbox...
RIP Inbox.

[jbudorick, 2015/08/21 02:27:38]

bundled in the inbox, mercifully.

[jbudorick, 2015/08/21 02:28:31]

Also, I intend this (along with the other email alerts in here) to be
short-lived, hence the TODO below

[mikecase (-- gone --), 2015/08/21 02:40:53]

Shouldn't this be sent to the infra-lab people and not you?
Is the chrome-android-device-alert@google.com email the infra-labs people?

[jbudorick, 2015/08/21 02:45:23]

yes

+          'chrome-android-device-alert@google.com']
+      subject = 'Unauthorized devices on %s' % buildbot_slavename
+      msg = ['The following devices are offline on %s' % buildbot_slavename]
+      msg += ['  %s' % ud for ud in unauthorized_devices]
+      msg += ['', 'Detected on %s #%s' % (buildbot_buildername,
+                                          buildbot_buildnumber)]
+      msg = '\n'.join(msg)
+      SendEmail(from_address, to_addresses, [], subject, msg)
+
   all_known_devices = list(device_serials | set(last_devices))
   device_list.WritePersistentDeviceList(last_devices_path, all_known_devices)
   device_list.WritePersistentDeviceList(last_missing_devices_path, missing_devs)
 
   if not all_known_devices:
     # This can happen if for some reason the .last_devices file is not
     # present or if it was empty.
     return ['No online devices. Have any devices been plugged in?']
   if missing_devs:
     devices_missing_msg = '%d devices not detected.' % len(missing_devs)
     bb_annotations.PrintSummaryText(devices_missing_msg)
     return ['Current online devices: %s' % ', '.join(d for d in device_serials),
             '%s are no longer visible. Were they removed?' % missing_devs]
   else:
     new_devs = device_serials - set(last_devices)
     if new_devs and os.path.exists(last_devices_path):
       bb_annotations.PrintWarning()
       bb_annotations.PrintSummaryText(
           '%d new devices detected' % len(new_devs))
       logging.info('New devices detected:')
       for d in new_devs:
         logging.info('  %s', d)
 
 
 def SendEmail(from_address, to_addresses, cc_addresses, subject, msg):
+  # TODO(jbudorick): Transition from email alerts for every failure to a more
+  # sustainable solution.
   msg_body = '\r\n'.join(['From: %s' % from_address,
                           'To: %s' % ', '.join(to_addresses),
                           'CC: %s' % ', '.join(cc_addresses),
                           'Subject: %s' % subject, '', msg])
   try:
     server = smtplib.SMTP('localhost')
     server.sendmail(from_address, to_addresses, msg_body)
     server.quit()
   except Exception:
     logging.exception('Failed to send alert email.')
@@ skipping 146 matching lines @@
     from_address = 'buildbot@chromium.org'
     to_addresses = ['chromium-android-device-alerts@google.com']
     bot_name = os.environ.get('BUILDBOT_BUILDERNAME')
     slave_name = os.environ.get('BUILDBOT_SLAVENAME')
     subject = 'Device status check errors on %s, %s.' % (slave_name, bot_name)
     SendEmail(from_address, to_addresses, [], subject, '\n'.join(err_msg))
 
   if options.device_status_dashboard:
     offline_devices = [
         device_utils.DeviceUtils(a)
-        for a in adb_wrapper.AdbWrapper.Devices(is_ready=False)
+        for a in adb_wrapper.AdbWrapper.Devices(desired_state=None)
         if a.GetState() == 'offline']
 
     perf_tests_results_helper.PrintPerfResult('BotDevices', 'OnlineDevices',
                                               [len(devices)], 'devices')
     perf_tests_results_helper.PrintPerfResult('BotDevices', 'OfflineDevices',
                                               [len(offline_devices)], 'devices',
                                               'unimportant')
     for dev, battery in zip(devices, batteries):
       perf_tests_results_helper.PrintPerfResult('DeviceBattery', str(dev),
                                                 [battery], '%',
@@ skipping 12 matching lines @@
 
   if num_failed_devs == len(devices):
     return 2
 
   if not devices:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())