[Android] Add email alerts on unauthorized devices.

build/android/pylib/device/adb_wrapper.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module wraps Android's adb tool.
 
 This is a thin wrapper around the adb interface. Any additional complexity
 should be delegated to a higher level (ex. DeviceUtils).
 """
 
@@ skipping 152 matching lines @@
     cls._RunAdbCmd(['start-server'], timeout=timeout, retries=retries,
                    cpu_affinity=0)
 
   @classmethod
   def GetDevices(cls, timeout=_DEFAULT_TIMEOUT, retries=_DEFAULT_RETRIES):
     """DEPRECATED. Refer to Devices(...) below."""
     # TODO(jbudorick): Remove this function once no more clients are using it.
     return cls.Devices(timeout=timeout, retries=retries)
 
   @classmethod
-  def Devices(cls, is_ready=True, long_list=False, timeout=_DEFAULT_TIMEOUT,
-              retries=_DEFAULT_RETRIES):
+  def Devices(cls, desired_state=_READY_STATE, long_list=False,

[rnephew (Wrong account), 2015/08/21 02:25:12]

Is is_ready used anywhere else that isn't changed in this cl?

I did a quick search on chromium cs and I think it is used in a unit test for
device utils. 

https://code.google.com/p/chromium/codesearch#search/&q=Devices%5C(%20is_read...

[jbudorick, 2015/08/21 02:27:38]

same name, mocking a function in AdbWrapper rather than a property of Devices

+              timeout=_DEFAULT_TIMEOUT, retries=_DEFAULT_RETRIES):
     """Get the list of active attached devices.
 
     Args:
-      is_ready: Whether the devices should be limited to only those that are
-        ready for use.
+      desired_state: If not None, limit the devices returned to only those
+        in the given state.
       long_list: Whether to use the long listing format.
       timeout: (optional) Timeout per try in seconds.
       retries: (optional) Number of retries to attempt.
 
     Yields:
       AdbWrapper instances.
     """
     lines = cls._RawDevices(long_list=long_list, timeout=timeout,
                             retries=retries)
     return [AdbWrapper(line[0]) for line in lines
             if ((long_list or len(line) == 2)
-                and (not is_ready or line[1] == _READY_STATE))]
+                and (not desired_state or line[1] == desired_state))]
 
   @classmethod
   def _RawDevices(cls, long_list=False, timeout=_DEFAULT_TIMEOUT,
                   retries=_DEFAULT_RETRIES):
     cmd = ['devices']
     if long_list:
       cmd.append('-l')
     output = cls._RunAdbCmd(cmd, timeout=timeout, retries=retries)
     return [line.split() for line in output.splitlines()[1:]]
 
@@ skipping 438 matching lines @@
   @property
   def is_emulator(self):
     return _EMULATOR_RE.match(self._device_serial)
 
   @property
   def is_ready(self):
     try:
       return self.GetState() == _READY_STATE
     except device_errors.CommandFailedError:
       return False