Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305383003: Move runtime helper for JSArrayBuffer onto objects. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-helpers-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move runtime helper for JSArrayBuffer onto objects. R=rossberg@chromium.org Committed: https://crrev.com/aca4a411e7082ffc790d79261ff383043de756ad Cr-Commit-Position: refs/heads/master@{#30387}

Patch Set 1 #

Patch Set 2 : Self-nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -87 lines) Patch
M src/api.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 4 chunks +6 lines, -59 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1314053003 Patch 1

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-26 13:08:15 UTC) #1
rossberg
lgtm
5 years, 3 months ago (2015-08-26 13:10:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305383003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305383003/20001
5 years, 3 months ago (2015-08-26 13:57:49 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 13:59:41 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 14:00:02 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/aca4a411e7082ffc790d79261ff383043de756ad
Cr-Commit-Position: refs/heads/master@{#30387}

Powered by Google App Engine
This is Rietveld 408576698