Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Side by Side Diff: src/factory.cc

Issue 1305383003: Move runtime helper for JSArrayBuffer onto objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-helpers-2
Patch Set: Self-nit. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/factory.h" 5 #include "src/factory.h"
6 6
7 #include "src/allocation-site-scopes.h" 7 #include "src/allocation-site-scopes.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 1825 matching lines...) Expand 10 before | Expand all | Expand 10 after
1836 size_t byte_length = number_of_elements * element_size; 1836 size_t byte_length = number_of_elements * element_size;
1837 1837
1838 obj->set_byte_offset(Smi::FromInt(0)); 1838 obj->set_byte_offset(Smi::FromInt(0));
1839 i::Handle<i::Object> byte_length_object = 1839 i::Handle<i::Object> byte_length_object =
1840 isolate()->factory()->NewNumberFromSize(byte_length); 1840 isolate()->factory()->NewNumberFromSize(byte_length);
1841 obj->set_byte_length(*byte_length_object); 1841 obj->set_byte_length(*byte_length_object);
1842 Handle<Object> length_object = NewNumberFromSize(number_of_elements); 1842 Handle<Object> length_object = NewNumberFromSize(number_of_elements);
1843 obj->set_length(*length_object); 1843 obj->set_length(*length_object);
1844 1844
1845 Handle<JSArrayBuffer> buffer = isolate()->factory()->NewJSArrayBuffer(); 1845 Handle<JSArrayBuffer> buffer = isolate()->factory()->NewJSArrayBuffer();
1846 Runtime::SetupArrayBuffer(isolate(), buffer, true, NULL, byte_length, 1846 JSArrayBuffer::Setup(buffer, isolate(), true, NULL, byte_length,
1847 SharedFlag::kNotShared); 1847 SharedFlag::kNotShared);
1848 obj->set_buffer(*buffer); 1848 obj->set_buffer(*buffer);
1849 Handle<FixedTypedArrayBase> elements = 1849 Handle<FixedTypedArrayBase> elements =
1850 isolate()->factory()->NewFixedTypedArray( 1850 isolate()->factory()->NewFixedTypedArray(
1851 static_cast<int>(number_of_elements), array_type, true); 1851 static_cast<int>(number_of_elements), array_type, true);
1852 obj->set_elements(*elements); 1852 obj->set_elements(*elements);
1853 return obj; 1853 return obj;
1854 } 1854 }
1855 1855
1856 1856
1857 Handle<JSDataView> Factory::NewJSDataView(Handle<JSArrayBuffer> buffer, 1857 Handle<JSDataView> Factory::NewJSDataView(Handle<JSArrayBuffer> buffer,
(...skipping 473 matching lines...) Expand 10 before | Expand all | Expand 10 after
2331 } 2331 }
2332 2332
2333 2333
2334 Handle<Object> Factory::ToBoolean(bool value) { 2334 Handle<Object> Factory::ToBoolean(bool value) {
2335 return value ? true_value() : false_value(); 2335 return value ? true_value() : false_value();
2336 } 2336 }
2337 2337
2338 2338
2339 } // namespace internal 2339 } // namespace internal
2340 } // namespace v8 2340 } // namespace v8
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698