Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314053003: Move runtime helper for JSWeakCollection onto objects. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-helpers-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move runtime helper for JSWeakCollection onto objects. R=rossberg@chromium.org Committed: https://crrev.com/3a8099c750566010c2152efd9238a44cefcd2c99 Cr-Commit-Position: refs/heads/master@{#30385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -78 lines) Patch
M src/api.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/runtime/runtime-collections.cc View 5 chunks +4 lines, -55 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-weaksets.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1312413002 Patch 1

Dependent Patchsets:

Issue 1305383003 Patch 1
Issue 1305383003 Patch 20001

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-26 12:37:48 UTC) #1
rossberg
lgtm
5 years, 3 months ago (2015-08-26 12:59:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314053003/1
5 years, 3 months ago (2015-08-26 13:08:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 13:18:53 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 13:19:16 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3a8099c750566010c2152efd9238a44cefcd2c99
Cr-Commit-Position: refs/heads/master@{#30385}

Powered by Google App Engine
This is Rietveld 408576698