src/factory.cc - Issue 1305383003: Move runtime helper for JSArrayBuffer onto objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1305383003: Move runtime helper for JSArrayBuffer onto objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-helpers-2

Patch Set: Self-nit. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index c73c9676e6398f18aceba570ea28da40ceb4251a..19939659649330ede03c94a3210c667a45e839bd 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1843,8 +1843,8 @@ Handle<JSTypedArray> Factory::NewJSTypedArray(ElementsKind elements_kind,

obj->set_length(*length_object);

Handle<JSArrayBuffer> buffer = isolate()->factory()->NewJSArrayBuffer();

- Runtime::SetupArrayBuffer(isolate(), buffer, true, NULL, byte_length,

- SharedFlag::kNotShared);

+ JSArrayBuffer::Setup(buffer, isolate(), true, NULL, byte_length,

+ SharedFlag::kNotShared);

obj->set_buffer(*buffer);

Handle<FixedTypedArrayBase> elements =

isolate()->factory()->NewFixedTypedArray(

« no previous file with comments | « src/bootstrapper.cc ('k') | src/objects.h » ('j') | no next file with comments »