cpplint.py pass on cc/(base|debug|quads|resources)/

This fixes all lint issues (except for false positives) in:

cc/base/
cc/debug/
cc/resources/
cc/quads/

BUG=144577
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190715

[danakj, 2013-03-25 17:23:31]

LGTM with some nits for the newly-chromified file.

https://codereview.chromium.org/13051003/diff/15001/cc/debug/ring_buffer.h
File cc/debug/ring_buffer.h (right):

https://codereview.chromium.org/13051003/diff/15001/cc/debug/ring_buffer.h#ne...
cc/debug/ring_buffer.h:12: template<typename T, size_t kSize>
Ooh.. informative.

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
File cc/resources/prioritized_resource_unittest.cc (right):

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:85:
->was_above_priority_cutoff_at_last_priority_update();
ಠ_ಠ

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:103: const size_t max_textures =
8;
no const, or kMaxTextures

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:147: const size_t max_textures =
8;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:152: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:209: const size_t max_textures =
8;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:214: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:282: const size_t max_textures =
4;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:345: const size_t max_textures =
16;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:350: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:431:
texture->SetTextureManager(0);
NULL

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:457: const size_t max_textures =
8;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:472: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:511: const size_t max_textures =
8;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:526: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:556: const size_t max_textures =
8;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:571: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:576: for (size_t i = 0; i < 6;
++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:578:
->set_request_priority(PriorityCalculator::VisiblePriority(true));
-> on prev line

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:579: for (size_t i = 6; i < 8;
++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:581:
->set_request_priority(PriorityCalculator::VisiblePriority(false));
-> moves up

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:605: const size_t max_textures =
8;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:612: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:657: const size_t max_textures =
4;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:665: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:706: const size_t max_textures =
5;
const

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:711: for (size_t i = 0; i <
max_textures; ++i)
{}

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:716:
->set_request_priority(PriorityCalculator::AllowVisibleOnlyCutoff() - 1);
move ->'s

https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
cc/resources/prioritized_resource_unittest.cc:747:
->set_request_priority(PriorityCalculator::AllowVisibleOnlyCutoff() - 1);
->

[jamesr, 2013-03-25 18:14:57]

On 2013/03/25 17:23:31, danakj wrote:
> LGTM with some nits for the newly-chromified file.
> 
> 
https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
> File cc/resources/prioritized_resource_unittest.cc (right):
> 
>
https://codereview.chromium.org/13051003/diff/15001/cc/resources/prioritized_...
> cc/resources/prioritized_resource_unittest.cc:85:
> ->was_above_priority_cutoff_at_last_priority_update();
> ಠ_ಠ
> 

Where should this line be broken?

[commit-bot: I haz the power, 2013-03-25 19:44:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/13051003/21001

[commit-bot: I haz the power, 2013-03-25 22:01:01]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-03-25 22:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/13051003/21001

[commit-bot: I haz the power, 2013-03-26 07:12:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/13051003/21001

[commit-bot: I haz the power, 2013-03-26 12:58:17]

Failed to apply patch for cc/resources/picture_layer_tiling.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/resources/picture_layer_tiling.cc
  Hunk #3 FAILED at 395.
  Hunk #4 succeeded at 522 (offset -1 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
cc/resources/picture_layer_tiling.cc.rej

Patch:       cc/resources/picture_layer_tiling.cc
Index: cc/resources/picture_layer_tiling.cc
diff --git a/cc/resources/picture_layer_tiling.cc
b/cc/resources/picture_layer_tiling.cc
index
5f74b704d19fbf9ebb1eca67e5797633ab7d40b9..fd4ce836c29cfecc71e60deff61c1a757143c15b
100644
--- a/cc/resources/picture_layer_tiling.cc
+++ b/cc/resources/picture_layer_tiling.cc
@@ -4,6 +4,7 @@
 
 #include "cc/resources/picture_layer_tiling.h"
 
+#include <algorithm>
 #include <cmath>
 
 #include "base/debug/trace_event.h"
@@ -131,7 +132,6 @@ void PictureLayerTiling::Invalidate(const Region&
layer_invalidation) {
   for (Region::Iterator region_iter(layer_invalidation);
        region_iter.has_rect();
        region_iter.next()) {
-
     gfx::Rect layer_invalidation = region_iter.rect();
     layer_invalidation.Intersect(gfx::Rect(layer_bounds_));
     gfx::Rect rect =
@@ -395,8 +395,7 @@ void PictureLayerTiling::UpdateTilePriorities(
 
   // Fast path tile priority calculation when both transforms are translations.
   if (last_screen_transform.IsIdentityOrTranslation() &&
-      current_screen_transform.IsIdentityOrTranslation())
-  {
+      current_screen_transform.IsIdentityOrTranslation()) {
     gfx::Vector2dF current_offset(
         current_screen_transform.matrix().get(0, 3),
         current_screen_transform.matrix().get(1, 3));
@@ -523,7 +522,7 @@ gfx::Rect
PictureLayerTiling::ExpandRectEquallyToAreaBoundedBy(
     gfx::Rect bounding_rect) {
   DCHECK(!starting_rect.IsEmpty());
   DCHECK(!bounding_rect.IsEmpty());
-  DCHECK(target_area > 0);
+  DCHECK_GT(target_area, 0);
 
   gfx::Rect rect = IntersectRects(starting_rect, bounding_rect);
   if (rect.IsEmpty())

[jamesr, 2013-03-26 18:06:17]

Committed patchset #6 manually as r190715 (presubmit successful).