Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304673002: Revert "Update SkLightingShader to support rotation" (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Update SkLightingShader to support rotation" This reverts commit 45b59ed6e4e231814dbdb9f707b3d2a7ee50de84. TBR=herb@google.com Committed: https://skia.googlesource.com/skia/+/f7d602a458f156723ec1a086f0fd132b1a9cc0e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -1550 lines) Patch
M gm/lightingshader.cpp View 5 chunks +19 lines, -65 lines 0 comments Download
M gyp/SampleApp.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M gyp/core.gypi View 2 chunks +1 line, -6 lines 0 comments Download
M gyp/effects.gypi View 3 chunks +4 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
A + include/effects/SkPoint3.h View 1 chunk +0 lines, -16 lines 0 comments Download
M samplecode/SampleLighting.cpp View 4 chunks +15 lines, -22 lines 0 comments Download
D src/core/SkLight.h View 1 chunk +0 lines, -56 lines 0 comments Download
D src/core/SkLightingShader.h View 1 chunk +0 lines, -101 lines 0 comments Download
D src/core/SkLightingShader.cpp View 1 chunk +0 lines, -738 lines 0 comments Download
D src/core/SkPoint3.h View 1 chunk +0 lines, -124 lines 0 comments Download
D src/core/SkPoint3.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
A + src/effects/SkLightingShader.h View 2 chunks +7 lines, -49 lines 0 comments Download
A + src/effects/SkLightingShader.cpp View 19 chunks +137 lines, -287 lines 0 comments Download
A + src/effects/SkPoint3.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304673002/1
5 years, 4 months ago (2015-08-19 19:57:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 20:05:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304673002/1
5 years, 4 months ago (2015-08-19 20:10:47 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 20:11:26 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f7d602a458f156723ec1a086f0fd132b1a9cc0e8

Powered by Google App Engine
This is Rietveld 408576698