Log error instead of CHECKing input audio sequence.

Log error instead of CHECKing input audio sequence.

The check was landed yesterday (https://codereview.chromium.org/1293503002/) and we hit it on bots already, which gives good information to investigate. We need to keep the bots green, so changing it to log error instead.

Implementation details:
AudioCapturerSource::CaptureCallback::OnCaptureError now takes a message string. The webrtc capturer implementation of that function the logs message to the WebRTC log. If the sequence is incorrect in AudioInputDevice::AudioThreadCallback::Process we call OnCaptureError and also log to the Chrome log.

TBR'ing Dale for media/base/audio_capturer_source.h - this CL fixes ~50 % fail on Linux tsan bot so I' want to land it asap.

TBR=dalecurtis@chromium.org

BUG=523224, 519336
Committed: https://crrev.com/f5157bcf31af480a5462729a117fb2742a3d1224
Cr-Commit-Position: refs/heads/master@{#344835}

[Henrik Grunell, 2015-08-21 11:27:21]

grunell@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2015-08-21 11:57:01]

https://codereview.chromium.org/1304173002/diff/1/media/audio/audio_input_dev...
File media/audio/audio_input_device.cc (right):

https://codereview.chromium.org/1304173002/diff/1/media/audio/audio_input_dev...
media/audio/audio_input_device.cc:183:
callback_->OnCaptureError("AudioInputDevice::OnStateChanged(ERROR)");
nit: "AudioInputDevice::OnStateChanged - audio thread still running"

https://codereview.chromium.org/1304173002/diff/1/media/audio/audio_input_dev...
media/audio/audio_input_device.cc:318: " Actual = " +
IntToString(buffer->params.id);
can we use StringPrintf?

[Henrik Grunell, 2015-08-21 13:15:33]

grunell@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Henrik Grunell, 2015-08-21 13:15:33]

https://codereview.chromium.org/1304173002/diff/1/media/audio/audio_input_dev...
File media/audio/audio_input_device.cc (right):

https://codereview.chromium.org/1304173002/diff/1/media/audio/audio_input_dev...
media/audio/audio_input_device.cc:183:
callback_->OnCaptureError("AudioInputDevice::OnStateChanged(ERROR)");
On 2015/08/21 11:57:01, tommi wrote:
> nit: "AudioInputDevice::OnStateChanged - audio thread still running"

Done.

https://codereview.chromium.org/1304173002/diff/1/media/audio/audio_input_dev...
media/audio/audio_input_device.cc:318: " Actual = " +
IntToString(buffer->params.id);
On 2015/08/21 11:57:01, tommi wrote:
> can we use StringPrintf?

Sure, done.

[tommi (sloooow) - chröme, 2015-08-21 14:12:34]

lgtm

[Henrik Grunell, 2015-08-21 14:16:00]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2015-08-21 14:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304173002/20001

[commit-bot: I haz the power, 2015-08-21 15:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 15:41:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Henrik Grunell, 2015-08-21 18:47:53]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2015-08-21 18:49:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304173002/20001

[commit-bot: I haz the power, 2015-08-21 19:37:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-21 19:38:31]

Patchset 2 (id:??) landed as
https://crrev.com/f5157bcf31af480a5462729a117fb2742a3d1224
Cr-Commit-Position: refs/heads/master@{#344835}