chrome/renderer/media/cast_receiver_audio_valve.h - Issue 1304173002: Log error instead of CHECKing input audio sequence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/media/cast_receiver_audio_valve.h

Issue 1304173002: Log error instead of CHECKing input audio sequence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/media/cast_receiver_audio_valve.h

diff --git a/chrome/renderer/media/cast_receiver_audio_valve.h b/chrome/renderer/media/cast_receiver_audio_valve.h

index 4ac8a93b433a726fdf86d19e50277085fbce171e..ebc1209ff25d241fecca24cc2efc692c9a196e77 100644

--- a/chrome/renderer/media/cast_receiver_audio_valve.h

+++ b/chrome/renderer/media/cast_receiver_audio_valve.h

@@ -27,7 +27,7 @@ class CastReceiverAudioValve :

int audio_delay_milliseconds,

double volume,

bool key_pressed) override;

- void OnCaptureError() override;

+ void OnCaptureError(const std::string& message) override;

// When this returns, no more calls will be forwarded to |cb|.

void Stop();

« no previous file with comments | « no previous file | chrome/renderer/media/cast_receiver_audio_valve.cc » ('j') | no next file with comments »