content/renderer/media/webrtc_audio_capturer.h - Issue 1304173002: Log error instead of CHECKing input audio sequence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.h

Issue 1304173002: Log error instead of CHECKing input audio sequence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc_audio_capturer.h

diff --git a/content/renderer/media/webrtc_audio_capturer.h b/content/renderer/media/webrtc_audio_capturer.h

index f1ada132fd5c97de08addb87a2c0bedb30f8ff5a..df566c0a2d8822260af4acd456d6a44902a5db90 100644

--- a/content/renderer/media/webrtc_audio_capturer.h

+++ b/content/renderer/media/webrtc_audio_capturer.h

@@ -129,7 +129,7 @@ class CONTENT_EXPORT WebRtcAudioCapturer

int audio_delay_milliseconds,

double volume,

bool key_pressed) override;

- void OnCaptureError() override;

+ void OnCaptureError(const std::string& message) override;

// Initializes the default audio capturing source using the provided render

// frame id and device information. Return true if success, otherwise false.

« no previous file with comments | « chrome/renderer/media/cast_receiver_session.cc ('k') | content/renderer/media/webrtc_audio_capturer.cc » ('j') | no next file with comments »