content/renderer/media/webrtc_audio_capturer.cc - Issue 1304173002: Log error instead of CHECKing input audio sequence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.cc

Issue 1304173002: Log error instead of CHECKing input audio sequence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc_audio_capturer.cc

diff --git a/content/renderer/media/webrtc_audio_capturer.cc b/content/renderer/media/webrtc_audio_capturer.cc

index df46265d8fb519f93c5ca69bd1de88851467fbe2..e1f71c3af038d7598fa44324afde62970b3b0073 100644

--- a/content/renderer/media/webrtc_audio_capturer.cc

+++ b/content/renderer/media/webrtc_audio_capturer.cc

@@ -561,8 +561,8 @@ void WebRtcAudioCapturer::Capture(const media::AudioBus* audio_source,

}

-void WebRtcAudioCapturer::OnCaptureError() {

- NOTIMPLEMENTED();

+void WebRtcAudioCapturer::OnCaptureError(const std::string& message) {

+ WebRtcLogMessage("WAC::OnCaptureError: " + message);

}

media::AudioParameters WebRtcAudioCapturer::source_audio_parameters() const {

« no previous file with comments | « content/renderer/media/webrtc_audio_capturer.h ('k') | media/audio/audio_input_device.cc » ('j') | no next file with comments »