Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303533004: Remove redundant null checks before instanceof checks. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, ianwen+watch_chromium.org, jam, yuzo+watch_chromium.org, pvalenzuela+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant null checks before instanceof checks. In Java, "x instanceof Y" can only be true if x is non-null, so it's not necessary to first check that "x != null". See: http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.20.2 This removes all such unnecessary null checks. Committed: https://crrev.com/9a9993f2b61f7b0eb947dda9b4c777bbdcf61e66 Cr-Commit-Position: refs/heads/master@{#344251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TitleBitmapFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/ColorSuggestionListAdapter.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 4 months ago (2015-08-18 19:10:28 UTC) #2
nyquist
lgtm
5 years, 4 months ago (2015-08-19 08:21:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303533004/1
5 years, 4 months ago (2015-08-19 15:41:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 16:43:09 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:44:22 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9a9993f2b61f7b0eb947dda9b4c777bbdcf61e66
Cr-Commit-Position: refs/heads/master@{#344251}

Powered by Google App Engine
This is Rietveld 408576698