sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java - Issue 1303533004: Remove redundant null checks before instanceof checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java

Issue 1303533004: Remove redundant null checks before instanceof checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java ('k') | ui/android/java/src/org/chromium/ui/ColorSuggestionListAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java

diff --git a/sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java b/sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java

index 01f0ff4bebde65585c2b1edd9c6ed549c9a24d60..34b52e912118b7bcd4b27759705bc811181fccc1 100644

--- a/sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java

+++ b/sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java

@@ -141,8 +141,8 @@ public class AccountHolder {

@Override

public boolean equals(Object that) {

- return that != null && that instanceof AccountHolder && mAccount

- .equals(((AccountHolder) that).getAccount());

+ return that instanceof AccountHolder

+ && mAccount.equals(((AccountHolder) that).getAccount());

}

public static Builder create() {