chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java - Issue 1303533004: Remove redundant null checks before instanceof checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java

Issue 1303533004: Remove redundant null checks before instanceof checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java

index e0d3e389388a99e042266d3fc2a7173b1c22eb84..72e11b997b3729a000f1551d5ba994034f3bd2e8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java

@@ -56,7 +56,7 @@ public class OmniboxResultsAdapter extends BaseAdapter {

@Override

public View getView(int position, View convertView, ViewGroup parent) {

SuggestionView suggestionView;

- if (convertView != null && convertView instanceof SuggestionView) {

+ if (convertView instanceof SuggestionView) {

suggestionView = (SuggestionView) convertView;

} else {

suggestionView = new SuggestionView(mContext, mLocationBar);