chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java - Issue 1303533004: Remove redundant null checks before instanceof checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

Issue 1303533004: Remove redundant null checks before instanceof checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

index 1e26c96a2cdd9d849ff40303e44547e940bd4f51..1c0ec2bc346185a0c2754ecdf1c73ee13886538a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

@@ -214,7 +214,7 @@ public class NavigationPopup extends ListPopupWindow implements AdapterView.OnIt

@Override

public View getView(int position, View convertView, ViewGroup parent) {

TextView view;

- if (convertView != null && convertView instanceof TextView) {

+ if (convertView instanceof TextView) {

view = (TextView) convertView;

} else {

view = mListItemFactory.createListItem();