Issue 1303343003: [ToolbarActionViewController] Update return type of GetId().

Issue 1303343003: [ToolbarActionViewController] Update return type of GetId(). (Closed)

Created:
5 years, 4 months ago by apacible

Modified:
5 years, 4 months ago

Reviewers:
Devlin, Peter Kasting

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[ToolbarActionViewController] Update return type of GetId(). Committed: https://crrev.com/3f73e9b3d070340d6d2efbd75b00cfd2b3a65c7b Cr-Commit-Position: refs/heads/master@{#344863}

Patch Set 2 : Changes per pkasting@'s comments. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
M	chrome/browser/ui/extensions/extension_action_view_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/extensions/extension_action_view_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/toolbar/media_router_action.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/toolbar/media_router_action.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/toolbar/toolbar_action_view_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/browser_actions_container.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/browser_actions_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 11 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Kasting

LGTM https://codereview.chromium.org/1303343003/diff/20001/chrome/browser/ui/toolbar/media_router_action.cc File chrome/browser/ui/toolbar/media_router_action.cc (right): https://codereview.chromium.org/1303343003/diff/20001/chrome/browser/ui/toolbar/media_router_action.cc#newcode51 chrome/browser/ui/toolbar/media_router_action.cc:51: return id_; You can eliminate |id_| and return ...

5 years, 4 months ago (2015-08-21 18:51:55 UTC) #4

apacible

https://codereview.chromium.org/1303343003/diff/20001/chrome/browser/ui/toolbar/media_router_action.cc File chrome/browser/ui/toolbar/media_router_action.cc (right): https://codereview.chromium.org/1303343003/diff/20001/chrome/browser/ui/toolbar/media_router_action.cc#newcode51 chrome/browser/ui/toolbar/media_router_action.cc:51: return id_; On 2015/08/21 18:51:55, Peter Kasting wrote: > ...

5 years, 4 months ago (2015-08-21 21:11:59 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303343003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303343003/40001

5 years, 4 months ago (2015-08-21 21:14:59 UTC) #9

commit-bot: I haz the power

5 years, 4 months ago (2015-08-21 21:21:55 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3f73e9b3d070340d6d2efbd75b00cfd2b3a65c7b
Cr-Commit-Position: refs/heads/master@{#344863}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages