chrome/browser/ui/toolbar/toolbar_action_view_controller.h - Issue 1303343003: [ToolbarActionViewController] Update return type of GetId().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_action_view_controller.h

Issue 1303343003: [ToolbarActionViewController] Update return type of GetId(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per pkasting@'s comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_action_view_controller.h

diff --git a/chrome/browser/ui/toolbar/toolbar_action_view_controller.h b/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

index 98b14ad8ab0f4abee4567d6f3d6d28b2d917ddf2..3b63c764f8fe09d9a3fad60c55de2a6ebe5ff6b6 100644

--- a/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

+++ b/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

@@ -31,7 +31,7 @@ class ToolbarActionViewController {

// Returns the unique ID of this particular action. For extensions, this is

// the extension id; for component actions, this is the name of the component.

- virtual const std::string& GetId() const = 0;

+ virtual std::string GetId() const = 0;

// Sets the view delegate, which can handle most of the front-end logic.

virtual void SetDelegate(ToolbarActionViewDelegate* delegate) = 0;