chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h - Issue 1303343003: [ToolbarActionViewController] Update return type of GetId().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h

Issue 1303343003: [ToolbarActionViewController] Update return type of GetId(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per pkasting@'s comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/media_router_action.cc ('k') | chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h

diff --git a/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h b/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h

index 8f43e3423e791d37e4ab0291d968343f4fd2416b..7340850fcff448ea7ed8ffa09ae73843f37cde62 100644

--- a/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h

+++ b/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h

@@ -15,7 +15,7 @@ class TestToolbarActionViewController : public ToolbarActionViewController {

~TestToolbarActionViewController() override;

// ToolbarActionViewController:

- const std::string& GetId() const override;

+ std::string GetId() const override;

void SetDelegate(ToolbarActionViewDelegate* delegate) override;

gfx::Image GetIcon(content::WebContents* web_contents,

const gfx::Size& size) override;