chrome/browser/ui/views/toolbar/browser_actions_container.cc - Issue 1303343003: [ToolbarActionViewController] Update return type of GetId().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 1303343003: [ToolbarActionViewController] Update return type of GetId(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per pkasting@'s comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc

diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc

index 07a96257b1671fb91f490f247cda5bb59bf468db..40ba0fd3e601849eeff60d7b80535864a352da4e 100644

--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc

+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc

@@ -141,7 +141,7 @@ void BrowserActionsContainer::Init() {

container_width_ = toolbar_actions_bar_->GetPreferredSize().width();

}

-const std::string& BrowserActionsContainer::GetIdAt(size_t index) const {

+std::string BrowserActionsContainer::GetIdAt(size_t index) const {

return toolbar_action_views_[index]->view_controller()->GetId();

}

« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.h ('k') | no next file » | no next file with comments »