Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303153003: Change Counter to be a CSSValue (Closed)

Created:
5 years, 4 months ago by sashab
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, esprehn, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change Counter to be a CSSValue Change Counter to CSSValueCounter, and remove counters from CSSPrimitiveValue. BUG=523893 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201095

Patch Set 1 #

Patch Set 2 : Removed things I said I would remove #

Patch Set 3 : Oilpan fix #

Total comments: 4

Patch Set 4 : Removed css text cache changes #

Patch Set 5 : Changed copyright year #

Total comments: 1

Patch Set 6 : Removed whitespace #

Patch Set 7 : Rebase & removed dependent patchsets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -166 lines) Patch
M Source/core/core.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A + Source/core/css/CSSCounterValue.h View 1 2 3 chunks +16 lines, -14 lines 0 comments Download
A Source/core/css/CSSCounterValue.cpp View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 6 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 3 4 5 7 chunks +0 lines, -44 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 2 3 6 chunks +14 lines, -0 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
D Source/core/css/Counter.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/css/Counter.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 4 chunks +12 lines, -10 lines 0 comments Download

Dependent Patchsets:

Issue 1304993002 Patch 80001
Issue 1304993002 Patch 100001
Issue 1304993002 Patch 120001

Messages

Total messages: 23 (11 generated)
Timothy Loh
https://codereview.chromium.org/1303153003/diff/40001/Source/core/css/CSSCounterValue.cpp File Source/core/css/CSSCounterValue.cpp (right): https://codereview.chromium.org/1303153003/diff/40001/Source/core/css/CSSCounterValue.cpp#newcode1 Source/core/css/CSSCounterValue.cpp:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 4 months ago (2015-08-21 07:33:13 UTC) #2
Timothy Loh
BTW I'd rather if we not change cssText caching here. I doubt that people are ...
5 years, 4 months ago (2015-08-21 08:21:56 UTC) #3
sashab
https://codereview.chromium.org/1303153003/diff/40001/Source/core/css/CSSCounterValue.cpp File Source/core/css/CSSCounterValue.cpp (right): https://codereview.chromium.org/1303153003/diff/40001/Source/core/css/CSSCounterValue.cpp#newcode1 Source/core/css/CSSCounterValue.cpp:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 3 months ago (2015-08-24 01:36:11 UTC) #4
Timothy Loh
lgtm https://codereview.chromium.org/1303153003/diff/80001/Source/core/css/CSSPrimitiveValue.cpp File Source/core/css/CSSPrimitiveValue.cpp (right): https://codereview.chromium.org/1303153003/diff/80001/Source/core/css/CSSPrimitiveValue.cpp#newcode1023 Source/core/css/CSSPrimitiveValue.cpp:1023: unrelated whitespace
5 years, 3 months ago (2015-08-24 01:44:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303153003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303153003/100001
5 years, 3 months ago (2015-08-24 01:51:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102895)
5 years, 3 months ago (2015-08-24 03:18:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303153003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303153003/100001
5 years, 3 months ago (2015-08-24 05:49:50 UTC) #12
Timothy Loh
Description still needs to be updated since the cssText cache change was removed
5 years, 3 months ago (2015-08-24 06:42:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303153003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303153003/120001
5 years, 3 months ago (2015-08-25 00:49:08 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103489)
5 years, 3 months ago (2015-08-25 01:57:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303153003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303153003/120001
5 years, 3 months ago (2015-08-25 02:43:58 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 03:21:19 UTC) #23
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201095

Powered by Google App Engine
This is Rietveld 408576698