Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 1303153003: Change Counter to be a CSSValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase & removed dependent patchsets Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
(...skipping 25 matching lines...) Expand all
36 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 36 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
37 */ 37 */
38 38
39 #include "config.h" 39 #include "config.h"
40 40
41 #include "core/CSSPropertyNames.h" 41 #include "core/CSSPropertyNames.h"
42 #include "core/CSSValueKeywords.h" 42 #include "core/CSSValueKeywords.h"
43 #include "core/StyleBuilderFunctions.h" 43 #include "core/StyleBuilderFunctions.h"
44 #include "core/StylePropertyShorthand.h" 44 #include "core/StylePropertyShorthand.h"
45 #include "core/css/BasicShapeFunctions.h" 45 #include "core/css/BasicShapeFunctions.h"
46 #include "core/css/CSSCounterValue.h"
46 #include "core/css/CSSCursorImageValue.h" 47 #include "core/css/CSSCursorImageValue.h"
47 #include "core/css/CSSGradientValue.h" 48 #include "core/css/CSSGradientValue.h"
48 #include "core/css/CSSGridTemplateAreasValue.h" 49 #include "core/css/CSSGridTemplateAreasValue.h"
49 #include "core/css/CSSHelper.h" 50 #include "core/css/CSSHelper.h"
50 #include "core/css/CSSImageSetValue.h" 51 #include "core/css/CSSImageSetValue.h"
51 #include "core/css/CSSLineBoxContainValue.h" 52 #include "core/css/CSSLineBoxContainValue.h"
52 #include "core/css/CSSPathValue.h" 53 #include "core/css/CSSPathValue.h"
53 #include "core/css/CSSPrimitiveValueMappings.h" 54 #include "core/css/CSSPrimitiveValueMappings.h"
54 #include "core/css/CSSPropertyMetadata.h" 55 #include "core/css/CSSPropertyMetadata.h"
55 #include "core/css/Counter.h"
56 #include "core/css/Pair.h" 56 #include "core/css/Pair.h"
57 #include "core/css/StylePropertySet.h" 57 #include "core/css/StylePropertySet.h"
58 #include "core/css/StyleRule.h" 58 #include "core/css/StyleRule.h"
59 #include "core/css/resolver/ElementStyleResources.h" 59 #include "core/css/resolver/ElementStyleResources.h"
60 #include "core/css/resolver/FilterOperationResolver.h" 60 #include "core/css/resolver/FilterOperationResolver.h"
61 #include "core/css/resolver/FontBuilder.h" 61 #include "core/css/resolver/FontBuilder.h"
62 #include "core/css/resolver/StyleBuilder.h" 62 #include "core/css/resolver/StyleBuilder.h"
63 #include "core/css/resolver/TransformBuilder.h" 63 #include "core/css/resolver/TransformBuilder.h"
64 #include "core/frame/LocalFrame.h" 64 #include "core/frame/LocalFrame.h"
65 #include "core/frame/Settings.h" 65 #include "core/frame/Settings.h"
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 state.style()->setContent(state.elementStyleResources().setOrPending FromValue(CSSPropertyContent, toCSSImageSetValue(item.get())), didSet); 702 state.style()->setContent(state.elementStyleResources().setOrPending FromValue(CSSPropertyContent, toCSSImageSetValue(item.get())), didSet);
703 didSet = true; 703 didSet = true;
704 } 704 }
705 705
706 if (item->isImageValue()) { 706 if (item->isImageValue()) {
707 state.style()->setContent(state.elementStyleResources().cachedOrPend ingFromValue(state.document(), CSSPropertyContent, toCSSImageValue(item.get())), didSet); 707 state.style()->setContent(state.elementStyleResources().cachedOrPend ingFromValue(state.document(), CSSPropertyContent, toCSSImageValue(item.get())), didSet);
708 didSet = true; 708 didSet = true;
709 continue; 709 continue;
710 } 710 }
711 711
712 if (item->isCounterValue()) {
713 CSSCounterValue* counterValue = toCSSCounterValue(item.get());
714 EListStyleType listStyleType = NoneListStyle;
715 CSSValueID listStyleIdent = counterValue->listStyleIdent();
716 if (listStyleIdent != CSSValueNone)
717 listStyleType = static_cast<EListStyleType>(listStyleIdent - CSS ValueDisc);
718 OwnPtr<CounterContent> counter = adoptPtr(new CounterContent(AtomicS tring(counterValue->identifier()), listStyleType, AtomicString(counterValue->sep arator())));
719 state.style()->setContent(counter.release(), didSet);
720 didSet = true;
721 }
722
712 if (!item->isPrimitiveValue()) 723 if (!item->isPrimitiveValue())
713 continue; 724 continue;
714 725
715 CSSPrimitiveValue* contentValue = toCSSPrimitiveValue(item.get()); 726 CSSPrimitiveValue* contentValue = toCSSPrimitiveValue(item.get());
716 727
717 if (contentValue->isString()) { 728 if (contentValue->isString()) {
718 state.style()->setContent(contentValue->getStringValue().impl(), did Set); 729 state.style()->setContent(contentValue->getStringValue().impl(), did Set);
719 didSet = true; 730 didSet = true;
720 } else if (contentValue->isAttr()) { 731 } else if (contentValue->isAttr()) {
721 // FIXME: Can a namespace be specified for an attr(foo)? 732 // FIXME: Can a namespace be specified for an attr(foo)?
722 if (state.style()->styleType() == NOPSEUDO) 733 if (state.style()->styleType() == NOPSEUDO)
723 state.style()->setUnique(); 734 state.style()->setUnique();
724 else 735 else
725 state.parentStyle()->setUnique(); 736 state.parentStyle()->setUnique();
726 QualifiedName attr(nullAtom, AtomicString(contentValue->getStringVal ue()), nullAtom); 737 QualifiedName attr(nullAtom, AtomicString(contentValue->getStringVal ue()), nullAtom);
727 const AtomicString& value = state.element()->getAttribute(attr); 738 const AtomicString& value = state.element()->getAttribute(attr);
728 state.style()->setContent(value.isNull() ? emptyString() : value.str ing(), didSet); 739 state.style()->setContent(value.isNull() ? emptyString() : value.str ing(), didSet);
729 didSet = true; 740 didSet = true;
730 } else if (contentValue->isCounter()) {
731 Counter* counterValue = contentValue->getCounterValue();
732 EListStyleType listStyleType = NoneListStyle;
733 CSSValueID listStyleIdent = counterValue->listStyleIdent();
734 if (listStyleIdent != CSSValueNone)
735 listStyleType = static_cast<EListStyleType>(listStyleIdent - CSS ValueDisc);
736 OwnPtr<CounterContent> counter = adoptPtr(new CounterContent(AtomicS tring(counterValue->identifier()), listStyleType, AtomicString(counterValue->sep arator())));
737 state.style()->setContent(counter.release(), didSet);
738 didSet = true;
739 } else { 741 } else {
740 switch (contentValue->getValueID()) { 742 switch (contentValue->getValueID()) {
741 case CSSValueOpenQuote: 743 case CSSValueOpenQuote:
742 state.style()->setContent(OPEN_QUOTE, didSet); 744 state.style()->setContent(OPEN_QUOTE, didSet);
743 didSet = true; 745 didSet = true;
744 break; 746 break;
745 case CSSValueCloseQuote: 747 case CSSValueCloseQuote:
746 state.style()->setContent(CLOSE_QUOTE, didSet); 748 state.style()->setContent(CLOSE_QUOTE, didSet);
747 didSet = true; 749 didSet = true;
748 break; 750 break;
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 return; 830 return;
829 case CSSValueSuper: 831 case CSSValueSuper:
830 svgStyle.setBaselineShift(BS_SUPER); 832 svgStyle.setBaselineShift(BS_SUPER);
831 return; 833 return;
832 default: 834 default:
833 ASSERT_NOT_REACHED(); 835 ASSERT_NOT_REACHED();
834 } 836 }
835 } 837 }
836 838
837 } // namespace blink 839 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698